[FIXED] EventLoop: Libuv may crash if connection destroyed while consuming #889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #889 +/- ##
==========================================
+ Coverage 70.26% 70.28% +0.01%
==========================================
Files 47 47
Lines 15560 15576 +16
Branches 3203 3209 +6
==========================================
+ Hits 10934 10948 +14
+ Misses 1547 1541 -6
- Partials 3079 3087 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…uming If the user destroys the connection while the read event was in progress it could be possible for the library to crash trying to process a read event. We need to immediately stop polling when the read event is removed. Changing also the way we retain the connection: we will now retain on the very first attach, and the adapters will have to call `natsConnection_Destroy()` when the event loop is fully detached. Resolves #888 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user destroys the connection while the read event was in progress it could be possible for the library to crash trying to process a read event.
We need to immediately stop polling when the read event is removed.
Changing also the way we retain the connection: we will now retain on the very first attach, and the adapters will have to call
natsConnection_Destroy()when the event loop is fully detached.Resolves #888
Signed-off-by: Ivan Kozlovic ivan@synadia.com