[FIXED] MicroServices: statistics error always incremented #894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handling a request that did not return an error would still lead to the number of errors to be incremented and the last error to be cleared. Resolves #893 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #894 +/- ##
==========================================
- Coverage 70.10% 70.08% -0.03%
==========================================
Files 47 47
Lines 15578 15579 +1
Branches 3210 3211 +1
==========================================
- Hits 10921 10918 -3
- Misses 1571 1576 +5
+ Partials 3086 3085 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling a request that did not return an error would still lead to the number of errors to be incremented and the last error to be cleared.
Resolves #893
Signed-off-by: Ivan Kozlovic ivan@synadia.com