[BUG] MessageConsumer.isFinished() not set properly in certain conditions #1339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottf
changed the title
scottf
commented
Jun 26, 2025
| @@ -67,8 +67,7 @@ public void pendingUpdated() {} | |||
|
|
|||
| @Override | |||
| public void heartbeatError() { | |||
| stopped.set(true); | |||
| finished.set(true); | |||
| finishAndClose(); | |||
There was a problem hiding this comment.
a heartbeat error on a fetch is terminal
scottf
commented
Jun 26, 2025
| @@ -86,8 +85,7 @@ public Message nextMessage() throws InterruptedException, JetStreamStatusChecked | |||
| if (m == null) { | |||
| // if there are no messages in the internal cache AND there are no more pending, | |||
| // they all have been read and we can go ahead and finish | |||
| finished.set(true); | |||
| lenientClose(); | |||
| finishAndClose(); | |||
There was a problem hiding this comment.
no more messages on a fetch is terminal
scottf
commented
Jun 26, 2025
| @@ -105,17 +103,15 @@ public Message nextMessage() throws InterruptedException, JetStreamStatusChecked | |||
| Message m = sub._nextUnmanagedNoWait(pullSubject); | |||
| if (m == null) { | |||
| // no message and no time left, go ahead and finish | |||
| finished.set(true); | |||
| lenientClose(); | |||
| finishAndClose(); | |||
There was a problem hiding this comment.
no more messages on a fetch is terminal
scottf
commented
Jun 26, 2025
| } | ||
| return m; | ||
| } | ||
|
|
||
| Message m = sub._nextUnmanaged(timeLeftNanos, pullSubject); | ||
| if (m == null && isNoWaitNoExpires) { | ||
| // no message and no wait, go ahead and finish | ||
| finished.set(true); | ||
| lenientClose(); | ||
| finishAndClose(); |
There was a problem hiding this comment.
no more messages on a fetch is terminal
scottf
commented
Jun 26, 2025
| @@ -67,7 +72,7 @@ void doSub() throws JetStreamApiException, IOException { | |||
| MessageHandler mh = userMessageHandler == null ? null : msg -> { | |||
| userMessageHandler.onMessage(msg); | |||
| if (stopped.get() && pmm.noMorePending()) { | |||
| finished.set(true); | |||
| finishAndClose(); | |||
There was a problem hiding this comment.
We have no more pending and the user has called stop, so we are finished with this consume
scottf
commented
Jun 26, 2025
| @@ -78,7 +83,12 @@ void doSub() throws JetStreamApiException, IOException { | |||
|
|
|||
| @Override | |||
| public void pendingUpdated() { | |||
| if (!stopped.get() && (pmm.pendingMessages <= thresholdMessages || (pmm.trackingBytes && pmm.pendingBytes <= thresholdBytes))) | |||
| if (stopped.get()) { | |||
There was a problem hiding this comment.
We have no more pending and the user has called stop, so we are finished with this consume
scottf
commented
Jun 26, 2025
| .group(group) | ||
| .minAckPending(5) | ||
| .build(); | ||
|
|
||
| FetchConsumeOptions fcoOverB = FetchConsumeOptions.builder() | ||
| .maxMessages(5) | ||
| .expiresIn(2000) | ||
| .expiresIn(3000) |
There was a problem hiding this comment.
this test was flapping, so added a little extra time
scottf
commented
Jun 26, 2025
| if (stopped.get()) { | ||
| finishAndClose(); | ||
| } | ||
| else { |
There was a problem hiding this comment.
If a heartbeat error occurs, we would usually just try again. But if the user had called stop, they've told us that we are finished.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1337
The new
finishAndClose()method set's the finish flag, stops the heartbeat timer and does a lenient close.