Skip to content

Conversation

@JustusBraun
Copy link
Collaborator

This PR adds:

  • MeshVertexCostsSparse message type
  • RViz support to visualize incremental cost updates
  • Allow to create MeshDisplay from topic in RViz

@JustusBraun JustusBraun requested a review from amock August 11, 2025 10:09
@amock amock self-assigned this Aug 11, 2025
Copy link
Collaborator

@amock amock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the little comments I made, the code looks good and is an improvement over the current state. It adds new interfaces (messages) so I would suggest to increase the major version of this repository to 2.1.0

Co-authored-by: Alexander Mock <amock@uos.de>
Copy link
Collaborator

@amock amock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for #63

@amock amock self-requested a review August 11, 2025 11:58
@JustusBraun JustusBraun force-pushed the feature/dynamic-cost-updates branch from 7eb1a24 to 1758fa7 Compare August 11, 2025 12:41
@amock amock merged commit ed3d289 into main Aug 11, 2025
2 checks passed
@Cakem1x
Copy link
Member

Cakem1x commented Aug 18, 2025

Thanks for the contributions!
@JustusBraun @amock Do you plan on developing further on the branch feature/dynamic-cost-updates?
If not, please delete the branch so we don't end up with a repo that has lots of stale branches. The github PR UI shows you a nice button for deleting a feature branch after a PR was merged. Should be someplace below all the comments vvvvvvvv

@amock amock deleted the feature/dynamic-cost-updates branch August 18, 2025 09:53
@amock
Copy link
Collaborator

amock commented Aug 18, 2025

@Cakem1x , I don't think we need this anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants