Test explicit rekkefoelge. Index shared across vedlegg types. #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flexable777
approved these changes
Aug 22, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR implements explicit ordering (rekkefoelge) for attachments in journal posts, ensuring a shared index across different attachment types (vedlegg and journalfoerteVedlegg).
- Adds
rekkefoelgefield to document structures and API payloads - Implements continuous indexing starting from 1 across all attachment types
- Updates journal post creation to include ordering information
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| JournalfoeringService.kt | Adds rekkefoelge field to MellomlagretDokument and includes it in journal post payload |
| DokumentEnhetService.kt | Implements shared indexing logic across vedlegg and journalfoerteVedlegg |
| JournalpostPayload.kt | Adds rekkefoelge field to VedleggReference data class |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| val journalfoerteVedlegg = input.dokumentreferanser.journalfoerteVedlegg?.mapIndexed { index, document -> | ||
| dokumentEnhetInputMapper.mapDokumentInputToJournalfoertVedlegg(document, index) | ||
| val journalfoerteVedlegg = input.dokumentreferanser.journalfoerteVedlegg?.map { document -> | ||
| dokumentEnhetInputMapper.mapDokumentInputToJournalfoertVedlegg(document, vedleggIndex++) |
There was a problem hiding this comment.
The log message on line 162 contains a typo: 'rekkefoelde' should be 'rekkefoelge' to match the field name used throughout the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.