Fikser Sonarqube issues #2267
Open
Fikser Sonarqube issues #2267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terjeofnorway
temporarily deployed
to
dev-gcp:dev1
GitHub Actions
Inactive
There was a problem hiding this comment.
Copilot reviewed 90 out of 91 changed files in this pull request and generated no comments.
Files not reviewed (1)
- Dockerfile: Language not supported
Comments suppressed due to low confidence (2)
packages/nextjs/src/components/_common/card/MicroCard/MicroCards.tsx:40
- Ensure that the computed key value is always defined and unique. Consider adding a fallback (e.g. a unique identifier) if both card.link?.url and card.link?.text are undefined.
<MicroCard {...card} key={card.link?.url ?? card.link?.text} />
packages/nextjs/src/components/_common/accordion/Accordion.tsx:63
- Verify that either item.anchorId or item.title is always provided to generate a unique key. If both could be undefined, consider including a fallback value to prevent duplicate or missing keys.
key={item.anchorId ?? item.title}
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
👀 Visual changes detected
Please review the screenshot changes before merging.
terjeofnorway
temporarily deployed
to
dev-gcp:dev2
GitHub Actions
Inactive
terjeofnorway
temporarily deployed
to
dev-gcp:dev2
GitHub Actions
Inactive
terjeofnorway
force-pushed
the
fikser-sonarqube-issues
branch
from
7b692f3 to
18e4f4c
Compare
|
terjeofnorway
temporarily deployed
to
dev-gcp:dev2
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oppsummering av hva som er gjort
Testing
Testes I dev