-
Notifications
You must be signed in to change notification settings - Fork 52
[ENH] Annotations in dss_line_iter plots and specification of a saving path #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Tip: in your base directory, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the dss_line_iter
plotting annotations and refactors how output figures are saved, as well as updates tests and examples to match the new API.
- Improved plot labels, titles, and added a legend for clarity.
- Removed the
prefix
parameter; introduceddirname
andextension
for saving control. - Updated tests and example script to use the new
dirname
argument.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
File | Description |
---|---|
tests/test_dss.py | Switched from prefix to dirname , adjusted fline , and updated test calls. |
meegkit/dss.py | Modified dss_line_iter signature, plotting annotations, and save logic. |
examples/example_dss_line.py | Reordered keyword args and added show=True ; needs updating for dirname . |
Comments suppressed due to low confidence (1)
tests/test_dss.py:152
- Add a test case to verify that files are saved correctly with the specified
extension
and naming pattern whendirname
is provided.
out, _ = dss.dss_line_iter(x, fline + 1, sr, show=True, dirname=tmpdir)
Ok thanks ! Sorry I don't contribute a lot |
No worries at all, happy to help! |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Modified annotations of dss_line_iter plots when show=True:
In dss_line_iter function: