Skip to content

Fixed isActive state and added isDisabled state in MenuItem Button #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 28, 2022
Merged

Fixed isActive state and added isDisabled state in MenuItem Button #1492

merged 4 commits into from
Dec 28, 2022

Conversation

goutham-subramanyam
Copy link
Contributor

@goutham-subramanyam goutham-subramanyam commented Dec 27, 2022 •
edited
Loading

Fixes #1482

  • Fixed: isActive prop of MenuItem.Button component.
  • Added: isDisabled prop to MenuItem.Button component.

Checklist

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary label (patch/minor/major - If package publish is required)
  • I have followed the suggested description format and styling

Reviewers

@praveen-murali-ind _a Please check and merge.

@goutham-subramanyam goutham-subramanyam added the minor Releases non-breaking noteworthy changes with backward compatible. label Dec 27, 2022
@amaldinesh7 amaldinesh7 added patch Releases small requests or bug fixes. and removed minor Releases non-breaking noteworthy changes with backward compatible. labels Dec 27, 2022
@github-actions
Copy link
Contributor

Label error. Requires exactly 1 of: major, minor, patch

@praveen-murali-ind
Copy link
Contributor

  • Updated active state color to blue to match Select component

Screenshot 2022-12-28 at 3 38 32 PM

Screenshot 2022-12-28 at 4 10 26 PM

  • Fixed active state hovering issue

ezgif-3-ac82493155

  • Updated disabled styles. Now we can apply the disabled state to danger style also.
  • Updated Storybook examples - added isActive and isDisabled states

@amaldinesh7 _a Could you please review.

@gitemit gitemit bot assigned amaldinesh7 and unassigned praveen-murali-ind Dec 28, 2022
@amaldinesh7 amaldinesh7 merged commit 49ff891 into main Dec 28, 2022
@amaldinesh7 amaldinesh7 deleted the 1482-fix-menuitem branch December 28, 2022 19:55
@neetogit-bot neetogit-bot bot added working A branch associated with this issue is created. PR The issue has a PR associated with it. labels Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@amaldinesh7 amaldinesh7

Labels
patch Releases small requests or bug fixes. PR The issue has a PR associated with it. working A branch associated with this issue is created.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix isActive prop and add disabled prop in Dropdown MenuItem
3 participants
@goutham-subramanyam @praveen-murali-ind @amaldinesh7