Skip to content

⚡ Bolt: Optimize and fix string replacement#1522

Closed
google-labs-jules[bot] wants to merge 3 commits into
masterfrom
bolt-string-replace-optimization-15846451580282937914
Closed

⚡ Bolt: Optimize and fix string replacement#1522
google-labs-jules[bot] wants to merge 3 commits into
masterfrom
bolt-string-replace-optimization-15846451580282937914

Conversation

@google-labs-jules
Copy link
Copy Markdown
Contributor

This pull request optimizes the stringReplace function and fixes a bug in its non-overlapping replacement logic. By delegating to the StringHelpers::replace_all function, it avoids repeated memory reallocations, leading to a significant performance improvement. Additionally, it corrects a flaw in the original implementation that produced incorrect results in certain scenarios.


PR created automatically by Jules for task 15846451580282937914 started by @Nelson-numerical-software

Optimizes the `stringReplace` function by delegating non-overlapping replacements to the more performant `StringHelpers::replace_all` function. This avoids repeated memory reallocations, which is significantly more efficient when the replacement string is longer than the search string.

This change also corrects a bug in the original non-overlapping replacement logic that caused incorrect output in some cases.
@google-labs-jules
Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Nelson-numerical-software Nelson-numerical-software deleted the bolt-string-replace-optimization-15846451580282937914 branch March 31, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants