⚡ Bolt: Optimize and fix string replacement#1522
⚡ Bolt: Optimize and fix string replacement#1522google-labs-jules[bot] wants to merge 3 commits into
Conversation
Optimizes the `stringReplace` function by delegating non-overlapping replacements to the more performant `StringHelpers::replace_all` function. This avoids repeated memory reallocations, which is significantly more efficient when the replacement string is longer than the search string. This change also corrects a bug in the original non-overlapping replacement logic that caused incorrect output in some cases.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
|
This pull request optimizes the
stringReplacefunction and fixes a bug in its non-overlapping replacement logic. By delegating to theStringHelpers::replace_allfunction, it avoids repeated memory reallocations, leading to a significant performance improvement. Additionally, it corrects a flaw in the original implementation that produced incorrect results in certain scenarios.PR created automatically by Jules for task 15846451580282937914 started by @Nelson-numerical-software