Skip to content

Commit 684c534

Browse files
Seanny123tcstewar
authored andcommitted
fixed syntax and formatting
1 parent 23bd21a commit 684c534

File tree

1 file changed

+34
-16
lines changed

1 file changed

+34
-16
lines changed

nengo_gui/components/netgraph.py

Lines changed: 34 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import threading
66

77
import nengo
8-
from nengo import spa
98
import json
109

1110
from nengo_gui.components.component import Component
@@ -15,6 +14,7 @@
1514
import nengo_gui.user_action
1615
import nengo_gui.layout
1716

17+
1818
class NetGraph(Component):
1919
"""Handles computations and communications for NetGraph on the JS side.
2020
@@ -53,6 +53,7 @@ def attach(self, page, config, uid):
5353
self.last_modify_time = None
5454
except TypeError: # happens if self.filename is None
5555
self.last_modify_time = None
56+
5657
self.last_reload_check = time.time()
5758

5859
def check_for_reload(self):
@@ -85,7 +86,7 @@ def reload(self, code=None):
8586
with self.page.lock:
8687
self._reload(code=code)
8788

88-
def _reload(self, code=None):
89+
def _reload(self, code=None): # noqa: C901
8990
"""Loads and executes the code, removing old items,
9091
updating changed items
9192
and adding new ones"""
@@ -138,7 +139,8 @@ def _reload(self, code=None):
138139
new_item = None
139140

140141
same_class = False
141-
for cls in [nengo.Ensemble, nengo.Node, nengo.Network, nengo.Connection]:
142+
for cls in [nengo.Ensemble, nengo.Node, nengo.Network,
143+
nengo.Connection]:
142144
if isinstance(new_item, cls) and isinstance(old_item, cls):
143145
same_class = True
144146
break
@@ -151,7 +153,8 @@ def _reload(self, code=None):
151153
elif not same_class:
152154
# don't allow changing classes
153155
keep_object = False
154-
elif self.get_extra_info(new_item) != self.get_extra_info(old_item):
156+
elif (self.get_extra_info(new_item) !=
157+
self.get_extra_info(old_item)):
155158
keep_object = False
156159

157160
if not keep_object:
@@ -191,7 +194,8 @@ def _reload(self, code=None):
191194
removed_items = list(removed_uids.values())
192195
for c in self.page.components[:]:
193196
for item in c.code_python_args(old_default_labels):
194-
if item not in self.uids.keys() and item not in collapsed_items:
197+
if (item not in self.uids.keys() and
198+
item not in collapsed_items):
195199

196200
# item is a python string that is an argument to the
197201
# constructor for the Component. So it could be 'a',
@@ -203,7 +207,7 @@ def _reload(self, code=None):
203207
# The following lambda should do this, handling both
204208
# the normal argument case and the keyword argument case.
205209
safe_eval = ('(lambda *a, **b: '
206-
'list(a) + list(b.values()))(%s)[0]')
210+
'list(a) + list(b.values()))(%s)[0]')
207211

208212
# this Component depends on an item inside a collapsed
209213
# Network, so we need to check if that component has
@@ -270,8 +274,8 @@ def _reload(self, code=None):
270274
index = component_uids.index(name)
271275
old_component = self.page.components[index]
272276
if isinstance(obj, (nengo_gui.components.SimControlTemplate,
273-
nengo_gui.components.AceEditorTemplate,
274-
nengo_gui.components.NetGraphTemplate)):
277+
nengo_gui.components.AceEditorTemplate,
278+
nengo_gui.components.NetGraphTemplate)):
275279
# just keep these ones
276280
components.append(old_component)
277281
else:
@@ -292,12 +296,14 @@ def _reload(self, code=None):
292296
# notifies SimControl to pause the simulation
293297
self.page.changed = True
294298

295-
def _reload_update_item(self, uid, old_item, new_item, new_name_finder):
299+
def _reload_update_item(self, uid, old_item, new_item, new_name_finder): # noqa: C901
296300
"""Tell the client about changes to the item due to reload."""
297301
changed = False
302+
298303
if isinstance(old_item, (nengo.Node,
299304
nengo.Ensemble,
300305
nengo.Network)):
306+
301307
old_label = self.page.get_label(old_item)
302308
new_label = self.page.get_label(
303309
new_item, default_labels=new_name_finder.known_name)
@@ -351,6 +357,7 @@ def _reload_update_item(self, uid, old_item, new_item, new_name_finder):
351357
return changed
352358

353359
def get_parents(self, uid, default_labels=None):
360+
"""Get parent networks for a connection"""
354361
while uid not in self.parents:
355362
net = self.networks_to_search.pop(0)
356363
net_uid = self.page.get_uid(net, default_labels=default_labels)
@@ -479,6 +486,8 @@ def act_create_modal(self, uid, **info):
479486
self.to_be_sent.append(dict(type='js', code=js))
480487

481488
def expand_network(self, network, client):
489+
"""Display an expanded network, including the root network"""
490+
482491
if not self.page.config[network].has_layout:
483492
pos = self.layout.make_layout(network)
484493
for obj, layout in pos.items():
@@ -491,36 +500,45 @@ def expand_network(self, network, client):
491500
else:
492501
parent = self.page.get_uid(network)
493502
for ens in network.ensembles:
494-
self.create_object(client, ens, type='ens', parent=parent)
503+
self.create_object(client, ens, obj_type='ens', parent=parent)
495504
for node in network.nodes:
496-
self.create_object(client, node, type='node', parent=parent)
505+
self.create_object(client, node, obj_type='node', parent=parent)
497506
for net in network.networks:
498-
self.create_object(client, net, type='net', parent=parent)
507+
self.create_object(client, net, obj_type='net', parent=parent)
499508
for conn in network.connections:
500509
self.create_connection(client, conn, parent=parent)
501510
self.page.config[network].expanded = True
502511

503-
def create_object(self, client, obj, type, parent):
512+
def create_object(self, client, obj, obj_type, parent):
513+
"""Send the JSON of the newly created objects to client-side"""
504514
uid = self.page.get_uid(obj)
515+
516+
# if the uid already exists, then it's already been inserted in
517+
# the netgraph, so don't send anything
505518
if uid in self.uids:
506519
return
507520

521+
self.uids[uid] = obj
522+
508523
pos = self.page.config[obj].pos
509524
if pos is None:
510525
import random
511526
pos = random.uniform(0, 1), random.uniform(0, 1)
512527
self.page.config[obj].pos = pos
528+
513529
size = self.page.config[obj].size
514530
if size is None:
515531
size = (0.1, 0.1)
516532
self.page.config[obj].size = size
533+
517534
label = self.page.get_label(obj)
518-
self.uids[uid] = obj
519-
info = dict(uid=uid, label=label, pos=pos, type=type, size=size,
535+
536+
info = dict(uid=uid, label=label, pos=pos, type=obj_type, size=size,
520537
parent=parent)
538+
info.update(self.get_extra_info(obj))
539+
521540
if type == 'net':
522541
info['expanded'] = self.page.config[obj].expanded
523-
info.update(self.get_extra_info(obj))
524542

525543
client.write_text(json.dumps(info))
526544

0 commit comments

Comments
 (0)