Skip to content

Fix tiny int handling #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 12, 2025

Conversation

thelonelyvulpes
Copy link
Contributor

@thelonelyvulpes thelonelyvulpes commented Jul 25, 2025

fixes #164 by casting the small i8s to i8 before casting to i64 to avoid the sign being ignored.
coauthor: @robsdedude

Copy link
Collaborator

@madchicken madchicken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The modification makes sense and seems to solve the issue

@madchicken madchicken requested a review from knutwalker August 3, 2025 10:02
Copy link
Collaborator

@knutwalker knutwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, thanks for the PR!

@knutwalker knutwalker merged commit 15ddd40 into neo4j-labs:main Aug 12, 2025
11 checks passed
@thelonelyvulpes thelonelyvulpes deleted the fix-tiny-int-handling branch August 15, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bolt integer coming back wrong?
3 participants