Use temp directory instead of cwd for test storage #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to apply only to I have no objections to the improvements except that if they are useful the module should use |
fiedukow
force-pushed
the
afie/tempDirFileInTest
branch
from
fe20da6 to
d589ad9
Compare
|
Done, converted this from |
|
One more thing, @fiedukow... Please add yourself to the list of contributors under |
fiedukow
force-pushed
the
afie/tempDirFileInTest
branch
from
d589ad9 to
34e2a10
Compare
|
Thanks, done! |
|
The reference as contributor is not complete, @fiedukow. There's another file you have to modify so the your name resolves to a link. |
In `test_36_unichars` we are writing local python file and them import it for testing purposes. So far this was done in a local directory (current working dir), but this is not ideal, as it might not be on a writable filesystem. For that reason it seems better to use a temporary directory, that is much more commonly provided in a writable form. This change makes that shift.
fiedukow
force-pushed
the
afie/tempDirFileInTest
branch
from
34e2a10 to
2bae900
Compare
|
Sorry for that, I missed that file. Hopefully fixed now 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
test_36_unicharswe are writing local python file and them import it for testing purposes.So far this was done in a local directory (current working dir), but this is not ideal, as it might not be on a writable filesystem. For that reason it seems better to use a temporary directory, that is much more commonly provided in a writable form.
This PR proposes that shift.