Fix incorrect unpin condition in get_cached_relkind

Kosntantin Knizhnik · Kosntantin Knizhnik · commit d62de29adeb2 · 2025-06-28T07:43:28.000+03:00
diff --git a/pgxn/neon/pagestore_client.h b/pgxn/neon/pagestore_client.h
@@ -294,7 +294,7 @@ typedef enum
 	RELKIND_UNKNOWN,
 	RELKIND_PERMANENT,
 	RELKIND_UNLOGGED,
-	RELKIND_UNLOGGED_BUILD //* buildig index for permanent relation */
+	RELKIND_UNLOGGED_BUILD /* buildig index for permanent relation */
 } RelKind;
 
 /* utils for neon relkind cache */
diff --git a/pgxn/neon/relkind_cache.c b/pgxn/neon/relkind_cache.c
@@ -187,7 +187,7 @@ get_cached_relkind(NRelFileInfo rinfo, RelKind* relkind)
 	if (found)
 	{
 		/* If relation persistence is known, then there is no need to pin it */
-		if (entry->relkind == RELKIND_UNKNOWN)
+		if (entry->relkind != RELKIND_UNKNOWN)
 		{
 			/* Fast path: normal (persistent) relation with kind stored in the cache */
 			if (--entry->access_count == 0)

Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,7 @@ get_cached_relkind(NRelFileInfo rinfo, RelKind* relkind)`
`187`	`187`	`if (found)`
`188`	`188`	`{`
`189`	`189`	`/* If relation persistence is known, then there is no need to pin it */`
`190`		`- if (entry->relkind == RELKIND_UNKNOWN)`
	`190`	`+ if (entry->relkind != RELKIND_UNKNOWN)`
`191`	`191`	`{`
`192`	`192`	`/* Fast path: normal (persistent) relation with kind stored in the cache */`
`193`	`193`	`if (--entry->access_count == 0)`