Skip to content

Conversation

mattiapenati
Copy link

@mattiapenati mattiapenati commented Apr 12, 2025

Crate tower-otel version 0.5.0 has been released. This version uses the newest release of opentelemetry and support for axum has been included.

The dependency has been updated to v0.5.0, so now neon does not rely on a specific revision of the crates but on a tagged release.


Upgrading opentelemetry to 0.29 has required quite a few changes.

  • The batch processor spawns a background thread of its own, so it do not need a runtime.
  • There's no feature to shutdown the global provider anymore. Have to carry around the provider manually

@github-actions github-actions bot added the external A PR or Issue is created by an external user label Apr 12, 2025
Copy link
Contributor

@conradludgate conradludgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot yet merge as is, as this now pulls in two versions of opentelemetry. We will need to upgrade our version of opentelemetry first to match.

@conradludgate conradludgate requested review from a team as code owners April 14, 2025 17:21
@conradludgate conradludgate added the approved-for-ci-run Changes are safe to trigger CI for the PR label Apr 14, 2025
@github-actions github-actions bot removed the approved-for-ci-run Changes are safe to trigger CI for the PR label Apr 14, 2025
@vipvap vipvap mentioned this pull request Apr 14, 2025
Copy link

github-actions bot commented Apr 14, 2025

8206 tests run: 7767 passed, 0 failed, 439 skipped (full report)


Flaky tests (6)

Postgres 15

Postgres 14

Code coverage* (full report)

  • functions: 33.1% (8992 of 27176 functions)
  • lines: 49.0% (77918 of 158902 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
6c6fe25 at 2025-04-16T17:39:18.955Z :recycle:

@conradludgate conradludgate added the approved-for-ci-run Changes are safe to trigger CI for the PR label Apr 14, 2025
@github-actions github-actions bot removed the approved-for-ci-run Changes are safe to trigger CI for the PR label Apr 14, 2025
@conradludgate conradludgate added the approved-for-ci-run Changes are safe to trigger CI for the PR label Apr 14, 2025
@github-actions github-actions bot removed the approved-for-ci-run Changes are safe to trigger CI for the PR label Apr 14, 2025
@conradludgate conradludgate added the approved-for-ci-run Changes are safe to trigger CI for the PR label Apr 16, 2025
@github-actions github-actions bot removed the approved-for-ci-run Changes are safe to trigger CI for the PR label Apr 16, 2025
@conradludgate conradludgate changed the title Bump tower-otel to 0.5.0 Bump opentelemetry to 0.29 Apr 16, 2025
# This revision uses opentelemetry 0.27. There's no tag for it.
tower-otel = { git = "https://github.com/mattiapenati/tower-otel", rev = "56a7321053bcb72443888257b622ba0d43a11fcd" }

tower-otel = { version = "0.5.0", features = ["axum"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default-features = false?

github-merge-queue bot pushed a commit that referenced this pull request Jul 22, 2025
This rebuilds #11552 on top the current Cargo.lock.

---------

Co-authored-by: Conrad Ludgate <conradludgate@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external A PR or Issue is created by an external user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants