Skip to content

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented May 26, 2025

Remove support for protocol version 2 between the walproposer and safekeeper.

Builds on #12020
Part of #10326

Copy link

If this PR added a GUC in the Postgres fork or neon extension,
please regenerate the Postgres settings in the cloud repo:

make NEON_WORKDIR=path/to/neon/checkout \
  -C goapp/internal/shareddomain/postgres generate

If you're an external contributor, a Neon employee will assist in
making sure this step is done.

@arpad-m
Copy link
Member Author

arpad-m commented May 26, 2025

Filing as WIP because I think it would be a good idea to keep support for now in order to test protocol v2 support in the safekeepers, i.e. as a thing for pytest.

Copy link

github-actions bot commented May 27, 2025

8481 tests run: 7932 passed, 0 failed, 549 skipped (full report)


Code coverage* (full report)

  • functions: 32.3% (9049 of 27992 functions)
  • lines: 48.5% (79444 of 163636 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
2ff680a at 2025-05-27T12:49:33.397Z :recycle:

github-merge-queue bot pushed a commit that referenced this pull request May 27, 2025
Some tests still explicitly specify version 3 of the safekeeper
walproposer protocol. Remove the explicit opt in from the tests as v3 is
the default now since #11518.

We don't touch the places where a test exercises both v2 and v3. Those
we leave for #12021.

Part of #10326
Base automatically changed from arpad/proto_version_v3_tests to main May 27, 2025 11:34
@arpad-m arpad-m force-pushed the arpad/walproposer_v3_only branch from 4c97681 to 2ff680a Compare May 27, 2025 11:39
@arpad-m arpad-m closed this Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant