Skip to content

Conversation

ephemeralsad
Copy link
Contributor

@ephemeralsad ephemeralsad commented Jun 14, 2025

Problem

The increment_generation logic currently returns the entire TenantShardPersistence object, even though only the generation field is needed.

Summary of Changes

  • Updated the query to return only the generation value instead of the full TenantShardPersistence struct.

Copy link

8481 tests run: 7900 passed, 0 failed, 581 skipped (full report)


Flaky tests (3)

Postgres 17

Postgres 14

Code coverage* (full report)

  • functions: 32.1% (9024 of 28104 functions)
  • lines: 48.4% (80219 of 165758 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
befab6b at 2025-06-14T11:56:37.542Z :recycle:

@ephemeralsad ephemeralsad changed the title Return only generation when increment storcon: Return only generation when increment Jun 16, 2025
@ephemeralsad ephemeralsad marked this pull request as ready for review June 16, 2025 07:27
@ephemeralsad ephemeralsad requested a review from a team as a code owner June 16, 2025 07:27
@ephemeralsad ephemeralsad requested a review from problame June 16, 2025 07:27
Copy link
Contributor

@problame problame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'm not a diesel expert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants