Store read_only flag in pageserver timelines #12534
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is useful also for the pageserver to store whether a timeline was
read_only
or not: we can stop/not run internal processes, not look for safekeepers at all, etc. Also, for the outside it is nicer if theTimelineInfo
contains whether a timeline is read only or not.So introduce a new
read_only
field toindex-part.json
. Currently, it's a one time choice one can't change (in either direction), and read-only property is non-recursive. Also, we only support it for branch timelines, so not for root timelines or imported timelines.Of course this only applies to new timelines, so the existing snapshots don't have this applied.
Follow-up of #12015