Log all GET requests in safekeepers, pageservers, etc #12613
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
problame
reviewed
Jul 15, 2025
There was a problem hiding this comment.
I think we reduced logging in the past because of log volume?
Do we have a metric that counts requests by method?
If not, I would like to see that metric added first.
Maybe we can move the logic from storcon to a central place?
8778 tests run: 8121 passed, 0 failed, 657 skipped (full report)Flaky tests (2)Postgres 16
Postgres 15
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
7d58647 at 2025-07-15T19:10:03.087Z :recycle: |
|
I don't have the time to follow up on this, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to log GET requests so that we can see if they show up at safekeepers or not.
requested for an incident: https://databricks.enterprise.slack.com/archives/C095WE2HTK7