Skip to content

Conversation

myrrc
Copy link
Contributor

@myrrc myrrc commented Jul 24, 2025

  • Return sub-actions time spans for prewarm, prewarm offload, and promotion in http handlers.
  • Set synchronous_standby_names=walproposer for promoted endpoints. Otherwise, walproposer on promoted standby ignores reply from safekeeper and is stuck on lsn COMMIT eternally.

Copy link

github-actions bot commented Jul 24, 2025

9108 tests run: 8455 passed, 0 failed, 653 skipped (full report)


Flaky tests (4)

Postgres 17

Postgres 15

Postgres 14

Code coverage* (full report)

  • functions: 34.7% (8840 of 25453 functions)
  • lines: 45.8% (71636 of 156549 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
887bea6 at 2025-07-31T10:47:10.477Z :recycle:

@myrrc myrrc force-pushed the myrrc/19011-prewarm-promote-time-spans branch from 323c60c to 5e5b8ca Compare July 25, 2025 11:38
@myrrc myrrc force-pushed the myrrc/19011-prewarm-promote-time-spans branch from 6c1cb11 to 5ff3e00 Compare July 29, 2025 09:49
@myrrc myrrc marked this pull request as ready for review July 30, 2025 13:02
@myrrc myrrc requested review from a team as code owners July 30, 2025 13:02
@myrrc myrrc changed the title Replica promotion: spec application issue, report timespans Prewarm cancellation and timespans reporting Jul 30, 2025
@myrrc myrrc force-pushed the myrrc/19011-prewarm-promote-time-spans branch from ef6a163 to dd33c5b Compare July 30, 2025 14:07
@myrrc myrrc requested a review from ololobus July 30, 2025 14:07
@myrrc myrrc requested a review from tristan957 July 30, 2025 14:45
@tristan957
Copy link
Member

This would have been easier to review in smaller PRs. It seems like there are 3 things going on with this one PR which you listed in the original description. Can you break it apart?

@myrrc
Copy link
Contributor Author

myrrc commented Jul 30, 2025

(3) is a one-liner, so I'll separate prewarm cancellation

@tristan957
Copy link
Member

Also,

Return sub-actions time spans for prewarm, prewarm offload, and promotion in http handlers.

Would be good to separate out. That will leave this PR in a much better state for a better review.

@myrrc
Copy link
Contributor Author

myrrc commented Jul 30, 2025

@tristan957 #12785

@myrrc
Copy link
Contributor Author

myrrc commented Jul 30, 2025

Would be good to separate out. That will leave this PR in a much better state for a better review.

Timespans reporting and fix for spec application are fine in a single PR

@myrrc myrrc changed the title Prewarm cancellation and timespans reporting Report timespans for promotion and prewarm Jul 30, 2025
@myrrc myrrc force-pushed the myrrc/19011-prewarm-promote-time-spans branch from abd2adc to 887bea6 Compare July 31, 2025 09:42
@myrrc myrrc enabled auto-merge July 31, 2025 09:47
@myrrc myrrc removed request for ololobus and tristan957 July 31, 2025 10:58
@myrrc myrrc added this pull request to the merge queue Jul 31, 2025
Merged via the queue into main with commit df4e37b Jul 31, 2025
102 checks passed
@myrrc myrrc deleted the myrrc/19011-prewarm-promote-time-spans branch July 31, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants