add pg_version to create timeline trace in pageserver #8964
+667
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orage image in local tilt setup
3857 tests run: 3742 passed, 1 failed, 114 skipped (full report)Failures on Postgres 16
Flaky tests (3)Postgres 16
Postgres 15
Postgres 14
Test coverage report is not availableThe comment gets automatically updated with the latest test results
e757bc9 at 2024-09-08T07:54:41.059Z :recycle: |
arpad-m
approved these changes
Sep 9, 2024
With them pg_upgrade v15 ->v16 --check passes, if all arguments are set. See slack for more details
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
…m/neondatabase/neon into hackathon/single_click_pg_upgrade
… code that runs initdb on a new brunch with a new version and tries to import it back to pageserver. This version fails on pageserver assertion ' cannot modify relation after advancing last_record_lsn (incoming_lsn=0/14F3030, last_record_lsn=0/2225360)' To test, create v15 tenant and try to branch using v16: cargo neon timeline branch --tenant-id $TENANT_ID --pg-version 16 --branch-name branch_16 TODO: figure out what LSN to update
This relies on the fact that we use neon_local and uses hardcoded neon_local paths
before importing it into the timeline. It must be equal to branching LSN. This version passes few more steps cargo neon timeline branch --tenant-id 14719455a7fbf1d257f427377d096cc2 --pg-version 16 --branch-name branch_16 cargo neon endpoint create ep_16 --pg-version 16 --tenant-id 14719455a7fbf1d257f427377d096cc2 --branch-name branch_16 cargo neon endpoint start ep_16 and if we connect to new endpoint, the version is correct and tables are there. But data is not visible for some reason
… in some timeline
…eline data. This fixed xlog flush request %X/%X is not satisfied error. See comments in the branch_timeline_impl().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to test custom storage image in local tilt setup
Problem
this is just preparing setup for hackaneon, DO NOT REVIEW
Summary of changes