Feature: migrate builtin commands

[TheRealLorenz]

See #3714
CC @justinmk

Things to note:

• LspStart starts the selected LSP and attaches to every buffer which has the right filetype. Should I only attach it to the current buffer?

• LspStop stops the selected LSP.

• LspRestart restart the selected LSPs, but I don't get how and why it used a timer.

• Should we add LspEnable? Maybe in a future PR.

EDIT:

Should I add checks for neovim 0.11?

Something like:

  if not has_eleven then
    error('nvim-lspconfig 2.x only supports vim.lsp.config. If you dont want to migrate, pin to nvim-lspconfig 1.x')
  end

[seblyng]

I don't think LspStart and LspRestart will work when root_dir is a function with this. I think you must do something like this:

if type(config.root_dir) == 'function' then
  ---@param root_dir string
  config.root_dir(bufnr, function(root_dir)
    config.root_dir = root_dir
    vim.schedule(function()
      vim.lsp.start(config, {
        bufnr = bufnr,
        reuse_client = config.reuse_client,
        _root_markers = config.root_markers,
      })
    end)
  end)
else
  vim.lsp.start(config, {
    bufnr = bufnr,
    reuse_client = config.reuse_client,
    _root_markers = config.root_markers,
  })
end

Inspiration taken from neovim source code, in lsp_enable_callback function in vim/lsp.lua

[TheRealLorenz]

I don't think LspStart and LspRestart will work when root_dir is a function with this. I think you must do something like this:

if type(config.root_dir) == 'function' then
  ---@param root_dir string
  config.root_dir(bufnr, function(root_dir)
    config.root_dir = root_dir
    vim.schedule(function()
      vim.lsp.start(config, {
        bufnr = bufnr,
        reuse_client = config.reuse_client,
        _root_markers = config.root_markers,
      })
    end)
  end)
else
  vim.lsp.start(config, {
    bufnr = bufnr,
    reuse_client = config.reuse_client,
    _root_markers = config.root_markers,
  })
end

Inspiration taken from neovim source code, in lsp_enable_callback function in vim/lsp.lua

Thank you, I totally missed that. The vim.lsp API is a little but cumbersome as for now.

[TheRealLorenz]

Opened a PR at neovim/neovim#33578 to make :LspStart less ugly.

[justinmk]

Nvim 0.11+, LspStop can do this, to "disable" the configs :

vim.lsp.enable(..., false)

Requested in #2216

[TheRealLorenz]

Yes, I'll add it. Should I re-enable the config in LspStart?

[TheRealLorenz]

@justinmk On further thinking, probably these commands do not suit vim.lsp quite well (at least semantically).

We could use LspEnable (with optional ++now), LspDisable, LspStart and LspStop "systemctl-like"

EDIT: or we could have enable + start as LspStart and disable + stop as LspStop