-
Notifications
You must be signed in to change notification settings - Fork 30
fix: W&B migration script #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed W&B entity, and defaulting Neptune projects to have `priv` visibility
Reviewer's GuideThis PR restricts W&B project fetching to a specified entity and defaults newly created Neptune projects to private visibility, with accompanying documentation updates. Sequence diagram for fetching W&B projects for a specific entitysequenceDiagram
participant Script
participant W&B_Client
Script->>W&B_Client: projects(entity=wandb_entity)
W&B_Client-->>Script: List of projects for entity
Script->>Script: Process projects
Class diagram for updated project creation logicclassDiagram
class WandbClient {
+projects(entity)
}
class NeptuneManagement {
+create_project(name, description, visibility)
}
class MigrationScript {
+copy_project(wandb_project)
}
WandbClient <.. MigrationScript : uses
NeptuneManagement <.. MigrationScript : uses
MigrationScript : +wandb_entity
MigrationScript : +neptune_workspace
MigrationScript : +wandb_project_name
MigrationScript : +visibility = "priv"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Consider making the default Neptune project visibility ('priv') a configurable option rather than hardcoding it in the script.
- The README's references to specific script line numbers (e.g., L319, L338) will quickly become outdated—consider pointing to function names or configuration settings instead.
- Add validation or a clear error message for when wandb_entity isn't supplied before calling client.projects(entity=wandb_entity).
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider making the default Neptune project visibility ('priv') a configurable option rather than hardcoding it in the script.
- The README's references to specific script line numbers (e.g., L319, L338) will quickly become outdated—consider pointing to function names or configuration settings instead.
- Add validation or a clear error message for when wandb_entity isn't supplied before calling client.projects(entity=wandb_entity).
## Individual Comments
### Comment 1
<location> `utils/migration_tools/from_wandb/wandb_to_neptune.py:107` </location>
<code_context>
</code_context>
<issue_to_address>
**issue (code-quality):** Unused skip comment ([`unused-skip-comment`](https://docs.sourcery.ai/Reference/Rules-and-In-Line-Suggestions/Python/Default-Rules/unused-skip-comment))
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
LeoRoccoBreedt
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
privvisibilityRelated to: <ClickUp/JIRA task name>
Any expected test failures?
Add a
[X]to relevant checklist items❔ This change
✔️ Pre-merge checklist
🧪 Test Configuration
Summary by Sourcery
Fix the W&B to Neptune migration script by scoping project fetches to the given entity and setting newly created Neptune projects to private by default, and update the README accordingly.
Bug Fixes:
Documentation:
Note
Filters W&B projects by entity and sets new Neptune projects to private visibility; updates README accordingly.
utils/migration_tools/from_wandb/wandb_to_neptune.py):client.projects(entity=wandb_entity).visibility="priv"instead of"workspace".utils/migration_tools/from_wandb/README.md):Written by Cursor Bugbot for commit 7ec5730. This will update automatically on new commits. Configure here.