Firmwares.get_firmware_by_uuid and multiple firmwares

[lawik]

The same firmware, with the same UUID can exist across many products and orgs. Typical for a dev product or similar.

When that happens this query will fail. Currently Devices.get_delta_or_firmware_url will hit it if deltas are enabled.

[joshk]

I'm confused, but I don't think your statement is correct.

We pull the product identifier from the firmware metadata, so right now a firmware can only belong to one product.

[jjcarstens]

I don't think this is a problem. We have had several firmwares duplicated across multiple orgs for quite some time. It has only been a problem as we've been testing new delta update changes

[joshk]

Sooooo yes @jjcarstens , you are right in that we do support the same Firmware being uploaded twice, and it is a bit funky.

I also agree that this isn't related, but it is an interesting thing to note.

When a Firmware is being uploaded we pull the product name from the firmware metadata.

There is a funky possibility in that you can upload a firmware into two Products connected to two different Orgs, as long as the Products have the same name.

Looking at the Firmwares table DB structure, we do have a unique index on product_id and uuid combined, so this would explain your issue.

If this is an expected possibility, we need to adjust all queries on the firmwares table to include the product_id, and I suspect the Deltas work might of not taken this into account?

[lawik]

Yeah, that is a much better specification of the problem.