Skip to content

Revert "perf: optimize instruction cache indexing to reduce local hotspots" #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2025
Merged

Revert "perf: optimize instruction cache indexing to reduce local hotspots" #463

merged 1 commit into from
Mar 10, 2025

Conversation

quake
Copy link
Member

@quake quake commented Mar 9, 2025

#460 introduced performance regression since develop branch is using different trace decoder with 0.24 branch, we should revert it and profile again.

@quake quake requested review from xxuejie and mohanson March 9, 2025 11:20
@quake quake merged commit 8f0277d into develop Mar 10, 2025
32 checks passed
@quake quake deleted the revert-460-quake/tweak-cache-key-develop branch March 10, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xxuejie xxuejie xxuejie approved these changes

@mohanson mohanson mohanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quake @xxuejie @mohanson