Remove secp256k1 benchmark #481
Conversation
tests/test_asm.rs
Outdated
| let isa = ISA_IMC; | ||
| let version = VERSION1; | ||
| let buffer = fs::read("benches/data/secp256k1_bench").unwrap().into(); | ||
| let buffer = fs::read("tests/programs/secp256k1").unwrap().into(); |
There was a problem hiding this comment.
I was just thinking: do we still need secp256k1 as a test here? I do recall test suite already contains secp256k1 test, can we simply remove it in this repo for simplicity?
We could probably draw a line: in this repo, we only do small, instruction level testing. And we leave it to the test suite repo for more, contract level testing.
Any thoughts?
There was a problem hiding this comment.
I agree.
Currently, all the test programs are hand-written except for the secp256k1 test; we can clearly know which instruction the test program is testing.
This makes the secp256k1 test look strange here.
Yes, I will add that. |
This PR removes the benchmark for secp256k1;
But I keep the secp256k1 binary because some testcases already depend on it.