Skip to content

Conversation

Guocork
Copy link

@Guocork Guocork commented Jul 10, 2025

What problem does this PR solve?

Issue Number: #4786

Problem Summary:
support Lz4 compress methods.

What is changed and how it works?

refactor compression moudle and add Lz4 compression method

Check List

Tests

  • Unit test

Release note

Title Only: Include only the PR title in the release note.

@Guocork Guocork requested a review from a team as a code owner July 10, 2025 08:27
@Guocork Guocork requested review from quake and removed request for a team July 10, 2025 08:27
@Guocork Guocork changed the title refactor compression moudle and add Lz4 compression method refactor compression module and add Lz4 compression method Jul 10, 2025
@driftluo
Copy link
Collaborator

Thank you for your contribution, but unfortunately, this PR will not be merged due to the following reasons:

  1. Although lz4's decompression capability is an order of magnitude higher than snappy's, its compression performance is similar, so overall the benefits are not high.
  2. Enabling multiple compression algorithms in the network module requires a complex process: from tentacle support to ckb full implementation, for the time being, there is no particularly strong impetus
  3. The bind implementation of lz4 does not support wasm yet, and a feature isolation process is required

@Guocork
Copy link
Author

Guocork commented Jul 11, 2025

Thank you for your contribution, but unfortunately, this PR will not be merged due to the following reasons:

  1. Although lz4's decompression capability is an order of magnitude higher than snappy's, its compression performance is similar, so overall the benefits are not high.
  2. Enabling multiple compression algorithms in the network module requires a complex process: from tentacle support to ckb full implementation, for the time being, there is no particularly strong impetus
  3. The bind implementation of lz4 does not support wasm yet, and a feature isolation process is required

Got it, thank you for your review and response.I'm interested in this project, but I noticed that there aren't many issues currently open in the CKB repository. Are there any issues I could contribute to?

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale To be closed due to a lack of activity label Aug 26, 2025
@chenyukang
Copy link
Collaborator

Thank you for your contribution, but unfortunately, this PR will not be merged due to the following reasons:

  1. Although lz4's decompression capability is an order of magnitude higher than snappy's, its compression performance is similar, so overall the benefits are not high.
  2. Enabling multiple compression algorithms in the network module requires a complex process: from tentacle support to ckb full implementation, for the time being, there is no particularly strong impetus
  3. The bind implementation of lz4 does not support wasm yet, and a feature isolation process is required

Got it, thank you for your review and response.I'm interested in this project, but I noticed that there aren't many issues currently open in the CKB repository. Are there any issues I could contribute to?

Hi @Guocork, thanks a lot for taking the time to contribute! 🙌

We used to have a bot that automatically closed inactive issues, but we realized that this isn’t ideal for an open-source project — it makes it harder for newcomers to discover issues they can work on.

So we removed the bot: #4943

I’ve also reopened some of those stale issues. You’ll find a few labeled good-for-first that could be a nice starting point:
https://github.com/nervosnetwork/ckb/issues?q=is%3Aissue%20state%3Aopen%20label%3Astale

(Some of them might already be outdated, so feel free to ask questions or point it out if something doesn’t look right.)

Really glad to have you here, and looking forward to more of your contributions! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale To be closed due to a lack of activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants