Skip to content

fix(cli): resolve malformed paths in schematic runner #3190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

fix(cli): resolve malformed paths in schematic runner #3190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/runners/abstract.runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export class AbstractRunner {
collect = false,
cwd: string = process.cwd(),
): Promise<null | string> {
const args: string[] = [command];
const commandArgs = command.split(' ');
const isWindows = platform() === 'win32';
const options: SpawnOptions = {
cwd,
Expand All @@ -24,7 +24,7 @@ export class AbstractRunner {
return new Promise<null | string>((resolve, reject) => {
const child: ChildProcess = spawn(
this.binary,
[...this.args, ...args],
[...this.args, ...commandArgs],
options,
);
if (collect) {
Expand Down
2 changes: 1 addition & 1 deletion lib/runners/schematic.runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { AbstractRunner } from './abstract.runner';

export class SchematicRunner extends AbstractRunner {
constructor() {
super(`node`, [`"${SchematicRunner.findClosestSchematicsBinary()}"`]);
super(`node`, [SchematicRunner.findClosestSchematicsBinary()]);
}

public static getModulePaths() {
Expand Down