-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
test(sample-05): added unit tests #8032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kamilmysliwiec
merged 15 commits into
nestjs:master
from
Tony133:test/sample--05-sql-typeorm
Oct 21, 2021
Merged
test(sample-05): added unit tests #8032
kamilmysliwiec
merged 15 commits into
nestjs:master
from
Tony133:test/sample--05-sql-typeorm
Oct 21, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build d10c5f1e-1a8b-4f21-9679-5b8b056b7086
💛 - Coveralls |
jmcdo29
requested changes
Sep 5, 2021
jmcdo29
requested changes
Oct 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made several comments. Take a look and address them as you can
Co-authored-by: Jay McDoniel <jmcdo29@gmail.com>
Tony133
commented
Oct 7, 2021
@jmcdo29 I made these changes it could go?
|
Conflicts resolved in |
Co-authored-by: Jay McDoniel <jmcdo29@gmail.com>
Conflicts resolved 👍 |
@kamilmysliwiec when you find some time can you check if I still have to make changes in this pull or can you merge? |
jmcdo29
approved these changes
Oct 20, 2021
Co-authored-by: Kamil Mysliwiec <mail@kamilmysliwiec.com>
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #1539
What is the new behavior?
added unit tests in sample
05-sql-typeorm
Does this PR introduce a breaking change?
Other information
This PR, added unit tests in sample
05-sql-typeorm