Skip to content

test(sample-05): added unit tests #8032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 21, 2021

Conversation

Tony133
Copy link
Contributor

@Tony133 Tony133 commented Sep 4, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #1539

What is the new behavior?

added unit tests in sample 05-sql-typeorm

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This PR, added unit tests in sample 05-sql-typeorm

@coveralls
Copy link

coveralls commented Sep 4, 2021

Pull Request Test Coverage Report for Build d10c5f1e-1a8b-4f21-9679-5b8b056b7086

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.207%

Totals Coverage Status
Change from base Build 19b05668-7122-423d-92a0-0f57cbcafcaa: 0.0%
Covered Lines: 5659
Relevant Lines: 6007

💛 - Coveralls

Copy link
Member

@jmcdo29 jmcdo29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made several comments. Take a look and address them as you can

Co-authored-by: Jay McDoniel <jmcdo29@gmail.com>
@Tony133
Copy link
Contributor Author

Tony133 commented Oct 7, 2021

@jmcdo29 I made these changes it could go?

  • row 36:
    save: jest.fn().mockResolvedValue(oneUser),
  • row 54:
      const oneUser = {
        firstName: 'firstName #1',
        lastName: 'lastName #1',
      };
      expect(
        service.create({
          firstName: 'firstName #1',
          lastName: 'lastName #1',
        }),
      ).resolves.toEqual(oneUser);

@Tony133
Copy link
Contributor Author

Tony133 commented Oct 14, 2021

Conflicts resolved in package.json

@Tony133
Copy link
Contributor Author

Tony133 commented Oct 18, 2021

Conflicts resolved 👍

@Tony133
Copy link
Contributor Author

Tony133 commented Oct 19, 2021

@kamilmysliwiec when you find some time can you check if I still have to make changes in this pull or can you merge?

Tony133 and others added 2 commits October 21, 2021 10:25
@kamilmysliwiec kamilmysliwiec merged commit b6f9f8c into nestjs:master Oct 21, 2021
@kamilmysliwiec
Copy link
Member

LGTM

@Tony133 Tony133 deleted the test/sample--05-sql-typeorm branch July 9, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants