Fixes #419: Register Branch custom permission actions#459
Draft
Fixes #419: Register Branch custom permission actions#459
Conversation
jnovinger
requested review from
a team and
jeremystretch
and removed request for
a team
Contributor
Author
|
Putting this in draft mode until netbox-community/netbox#21560 is merged |
Declare custom permission actions (sync, merge, migrate, revert, archive) via Django's Meta.permissions on the Branch model. NetBox's register_models() auto-registers these, making the imperative register_model_actions() call in ready() unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #419
Register the five Branch model custom actions (
sync,merge,migrate,revert,archive) with NetBox core viaregister_model_actions(). This makes them discoverable as checkboxes in the ObjectPermission form instead of requiring freeform text entry.Depends on netbox-community/netbox#21357.