Feature request - tenant/site config for agent

[sepetuks]

We have multiple customers in separate L2 domains/VRFs.
Any of them can use same subnet in their network (kind of duplicate prefixes)
Would it be possible to have config parameter for agent that it explicitly define for which tenant/site this agent is collecting data? Or maybe VRF?

[leoparente]

hi @sepetuks we are currently working to support more data models on diode SDK. Therefore, it will improve the supported netbox types on orb-agent and its backends. If applicable for your use case, a temporary solution would be to add this information as Tags in the agent policy : https://github.com/netboxlabs/orb-agent/blob/develop/docs/backends/network_discovery.md#defaults

[sepetuks]

hi @sepetuks we are currently working to support more data models on diode SDK. Therefore, it will improve the supported netbox types on orb-agent and its backends. If applicable for your use case, a temporary solution would be to add this information as Tags in the agent policy : https://github.com/netboxlabs/orb-agent/blob/develop/docs/backends/network_discovery.md#defaults

Hi, thanks for proposal but that will not solve issue if same subnets are being used in 2 different VRFs. Netbox will not be able to distinguish into which one to assign collected data. So I just need to wait untill data models are expanded.

[Marcussjogren]

hi @sepetuks we are currently working to support more data models on diode SDK. Therefore, it will improve the supported netbox types on orb-agent and its backends. If applicable for your use case, a temporary solution would be to add this information as Tags in the agent policy : https://github.com/netboxlabs/orb-agent/blob/develop/docs/backends/network_discovery.md#defaults

Hi, thanks for proposal but that will not solve issue if same subnets are being used in 2 different VRFs. Netbox will not be able to distinguish into which one to assign collected data. So I just need to wait untill data models are expanded.

What you probably could do is to tag them in the orb agent, and then have a script running that looks for tag "customer1" and then checking if the address has "customer1" configured as tenant. If not, it will add it.

But thats just a workaround until proper modelling of Diode data has been developed.

[sepetuks]

if I use following config:

network_discovery:
  policy_1:
    config:
      defaults:
        tenant: Customer 1
        vrf: VRF1
      schedule: "*/5 * * * *"
      timeout: 5
    scope:
      targets:
         - 10.10.10.0/24
         - 10.10.10.254

The defaults are not passed to diode server. The data load simply do not get that data,
based on code https://github.com/netboxlabs/orb-discovery/blob/develop/network-discovery/config/config.go#L53 it looks it should be possible to pass vrf and tenant?

[leoparente]

hi @sepetuks can you try to pull latest develop image with docker pull netboxlabs/orb-agent:develop and run agent using this image to validate this feature?

[sepetuks]

It looks there is still some errors:

• For some reason it also tries to populate data where RD is also same as VRF name. Which is not expected behavior. I would expect only VRF name to be passed. Now result was that new VRF was created.
• Another issue with tenant: my tenant has required custom field and I get error because required data was not provided (for custom field)