-
Notifications
You must be signed in to change notification settings - Fork 113
Feature/auto completion cli #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LanutiEmanuele
wants to merge
6
commits into
develop
Choose a base branch
from
feature/auto_completion_cli
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emanuele Lanuti <emanuele.lanuti@stardustsystems.net>
Signed-off-by: Emanuele Lanuti <emanuele.lanuti@stardustsystems.net>
Signed-off-by: Emanuele Lanuti <emanuele.lanuti@stardustsystems.net>
Signed-off-by: Emanuele Lanuti <emanuele.lanuti@stardustsystems.net>
Signed-off-by: Emanuele Lanuti <emanuele.lanuti@stardustsystems.net>
LucaNicosia
reviewed
May 20, 2025
fea8d7b
to
76fbb42
Compare
rickstardust
approved these changes
May 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sepehr-A
reviewed
May 26, 2025
Signed-off-by: Emanuele Lanuti <emanuele.lanuti@stardustsystems.net>
71c48ae
to
225dba8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces autocompletion support in the CLI by replacing the official
nubia
package with a custom fork .Previously, CLI commands like:
address show vrf=
would not provide any dynamic suggestions. Now, this command and others support real-time autocompletion for available options, improving user experience and CLI discoverability.
Key implementation details:
Replaced nubia with a custom fork.
Modified several CLI functions to align with the fork structure.
Added autocompletion definitions and helper functions.
Type of change
New feature (non-breaking change which adds functionality)
New Behavior
When using the CLI, users can now trigger autocompletion on supported arguments and filters, Suggestions will appear based on available options.
Contrast to Current Behavior
Before:
After:
Discussion: Benefits and Drawbacks
Benefits
Improves productivity and usability of CLI
Backward-compatible; does not impact command execution
Drawbacks
CLI functions refactored to support base class requirements
Requires Poetry environment update (poetry install) to fetch the fork
Proposed Release Note Entry
nubia
package to a custom forkComments
The autocompletion feature was tested manually and with automated tests.
Requires running poetry install after pulling the branch to ensure correct dependencies are installed (replaces standard nubia package).
Still writing tests
Double Check
develop
branch.develop
branch.--signoff
applied