Interface assert: fixed vlan mismatch assert for mlag peerlinks #989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AndryNick98 <andrea.nicoletti@stardustsystems.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #987
Description
Due to an issue reported by an user, we noticed that when a user run an
interface asserton a dataset containing mlag peerlinks, the assert may or may not pass randomly.The problem is that when we evaluate the vlan mismatch for mlag peerlinks, we were looking just for
indexPeerless than 0 or greater than 0, without never checking the entry at index 0. This was the cause of that random behavior.This PR fix it.
Type of change
Proposed Release Note Entry
Fixed interface assert vlan mismatch for mlag interfaces
Double Check
developbranch.developbranch.--signoffapplied