-
Notifications
You must be signed in to change notification settings - Fork 56
Fe public exposure #969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GiovanniRusso2002
wants to merge
51
commits into
netgroup-polito:master
Choose a base branch
from
LilloBarilotto:fe-public-exposure
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fe public exposure #969
GiovanniRusso2002
wants to merge
51
commits into
netgroup-polito:master
from
LilloBarilotto:fe-public-exposure
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @GiovanniRusso2002. Thanks for your PR. I am @kingmakerbot.
Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:
|
- Replace (status as any) === Phase2.Off with direct comparison - Fix TypeScript linting error @typescript-eslint/no-explicit-any - Apply Prettier formatting fixes to all frontend files
- Update SharedVolume type from Phase3 to Phase5 enum - Fix RowShVolStatus component to use Phase5 instead of Phase3 - Add allowPublicExposure property to Template mapping in getTemplatesMapped - Update imports to use Phase5 instead of Phase3 - Regenerate GraphQL types to ensure compatibility - Fix all TypeScript compilation errors for Docker build
/deploy-staging |
- Add allowPublicExposure field to GraphQL queries and subscriptions for templates - Add publicExposure fields (spec and status) to instance queries and subscriptions - Update subscription detection logic to track publicExposure changes in real-time - Fix PublicExposureModal to allow deletion of all port exposures - Enhance makeGuiInstance and getManagerInstances to use publicExposureStatus - Update getSubObjTypeCustom and getSubObjTypeK8s to detect publicExposure changes - Add informational alert when no ports are exposed in modal - Regenerate GraphQL types with new schema fields Fixes real-time UI updates for public exposure changes and enables complete port exposure management including disabling all exposures.
/deploy-staging |
/deploy-staging |
…o/CrownLabs into fe-public-exposure
/deploy-staging |
/deploy-staging |
/deploy-staging |
/deploy-staging |
/deploy-staging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Public Exposure button has been added to open a panel that allows you to insert the desired ports.