fix: update deno run commands to set node-modules-dir to false #6771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeChampion
force-pushed
the
jake/build
branch
3 times, most recently
from
aaea002 to
962297f
Compare
JakeChampion
changed the title
JakeChampion
changed the title
| (Netlify Build completed in 1ms)␊ | ||
| Build step duration: Netlify Build completed in 1ms` | ||
|
|
||
| ## In integration dev mode, install local plugins and install the integration when forcing build |
Member
There was a problem hiding this comment.
How come this is getting removed?
Contributor
Author
There was a problem hiding this comment.
This test does not exist - which is why the snapshot was removed when I regenerated snapshots
| importMapData, | ||
| vendorDirectory, | ||
| } | ||
| const flags = ['--allow-all', '--no-config', `--import-map=${bundlerImportMap}`] |
Member
There was a problem hiding this comment.
Is it necessary to do this on the ESZIP flow as well? I suppose it shouldn't have any negative impact since in this case we're only running the ESZIP bundler script and we won't find any node modules in there.
Contributor
Author
There was a problem hiding this comment.
I believe this is required yeah, the .deno folder was being made until I also added this flag here
Reorders the code to add vendor import maps before bundle generation starts. This ensures the import map is properly initialized with vendor dependencies before any bundling logic executes, preventing potential issues with missing dependencies during the bundling process.
Enables manual node modules directory handling in both eszip and tarball bundling formats. This change provides more granular control over how node modules are resolved during the bundling process, ensuring consistent behavior across different bundling targets.
JakeChampion
force-pushed
the
jake/build
branch
from
83902f0 to
3893be8
Compare
JakeChampion
force-pushed
the
jake/build
branch
from
3893be8 to
654f9fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
--node-modules-dir=falseflag to deno bundle commands in both tarball and eszip bundling formats. This ensures consistent handling of node modules during edge function bundling and updates related tests to reflect the new flag usage. The change improves reliability of the bundling process by explicitly disabling node modules directory handling.This will stop our bundling step from accidentally adding a
.denofolder into thenode_modulesfolder, which was causing issues for builds which use a cachednode_modulesfolderThis was a bit difficult to test out locally, I instead did a manual test using buildbot via https://github.com/netlify/buildbot/pull/3874 and then making a site's build use this custom buildbot image