Skip to content

feat: Attempt to retreive full objects on server during POST #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2025

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Apr 17, 2025

New Pull Request Checklist

Issue Description

  • Sometimes, when creating objects, the server may return a ParsePointer instead of the realized object.
  • There's an issue when using mergeable on ParseInstallation's' and properties that are automatically computed, such as appVersion are not sent to the server

Closes: FILL_THIS_OUT

Approach

  • Attempt to retrieve the realized object before returning to the function call-site
  • When using mergeable on ParseInstallation, always retain all automatically computed properties so the server always receives the latest update of a ParseInstallation.

TODOs before merging

  • Add tests
  • Add entry to changelog

Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.93%. Comparing base (e4d22f7) to head (b0f41ad).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
+ Coverage   91.75%   91.93%   +0.18%     
==========================================
  Files         179      179              
  Lines       15985    16023      +38     
==========================================
+ Hits        14667    14731      +64     
+ Misses       1318     1292      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cbaker6 cbaker6 merged commit c9d8c95 into main Apr 17, 2025
12 of 13 checks passed
@cbaker6 cbaker6 deleted the improveCreateObject branch April 17, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant