Comment: comment 모듈 추가 및 application, api 작성 #68

seonghooni · 2025-05-03T14:37:09Z

Pull Request

Issues

Resolves [MAIN] Comment, Reply Domain 구현 #57
Resolves [SUB-ISSUE] Comment: 모듈별 베이스 패키지 구분 #89

Description

api, application, driven/rdb, driving/web 모듈 추가
- comment 및 reply에 대한 domain, excepltion, readmodel 모듈을 작성했습니다.
- comment 및 reply에 대한 port를 작성했습니다.
- comment 및 reply에 대한 entity, persistence를 작성했습니다.
postgresql migration script를 작성했습니다.
basePackage 컨벤션에 맞게 리팩토링 진행했습니다.

How Has This Been Tested?

Comment, Reply에 대한 Create, Update, Delete API를 실행한 후,
Read API를 실행시킨 결과입니다.

Additional Notes

현재 작성한 댓글 조회 기능에서 댓글과 대댓글을 10개씩 가져오는데,
이 과정에서 N+1 비효율이 발생합니다.

게시물에 대한 댓글을 최대 10개, 또한 각각의 댓글에 대한 대댓글을 최대 10개 불러와야 하지만,
QueryDSL에서 제공하는 기본 구문으로는 이 코드를 최적화 할 수 없습니다.

nettee.comment.application.service.CommentQueryService의 함수입니다.

public List<CommentDetail> getCommentsByBoardId(Long boardId) {
        var comments = commentQueryRepositoryPort.findPageByBoardId(boardId, 0, 10);

        // comment별로 reply를 10개씩 가져옴
        **// 현재 N+1 이므로, 최대 11(1+10)개의 쿼리를 발생시킴**
        var result = comments.stream()
            .map(comment -> {
                var replies = replyQueryRepositoryPort.findPageByCommentId(comment.id(), 0, 10);

                return CommentDetail.builder()
                    .id(comment.id())
                    .content(comment.content())
                    .status(comment.status())
                    .createdAt(comment.createdAt())
                    .updatedAt(comment.updatedAt())
                    .replies(replies)
                    .build();
            }).collect(Collectors.toList());

        return result;
    }

위 코드를 NativeQuery를 써서 최적화를 할지
vs
11개의 쿼리는 N+1 문제일지라도 예측 가능한 범위 내에 있기 때문에 그대로 둘지

에 대한 고민은 해봐야 할 것 같습니다.

…radle.kts, yml, build.gradle.kts)

merge-simpson · 2025-05-05T14:34:41Z

services/comment/comment.settings.gradle.kts

+project(":comment:application").projectDir = comment("application")
+project(":comment:rdb-adapter").projectDir = comment("rdb")
+project(":comment:webmvc-adapter").projectDir = comment("web-mvc")


❗️ "web-mvc" 폴더가 존재하지 않습니다.

단, 이것을 해결해도 다른 오류가 남아 있어 정상적으로 실행되지는 않습니다.
(자주 언급되고 있는 오류이므로 다른 리뷰보다 먼저 싱글 코멘트로 남기겠습니다.)

silberbullet · 2025-05-06T07:35:41Z

services/comment/comment.settings.gradle.kts

+val comment = getDirectories("services", "comment")
+
+// SERVICE/COMMENT
+include(


타 도메인과 중복되는 모듈명으로 부터 main-runner 모듈에서 yml 파일 import 부분에 트러블슈팅이 있었습니다!

하기와 같은 수정을 요청 드립니다.

수정 예시

include( ":comment", ":comment:comment-api", ":comment:comment-api-domain", ":comment:comment-api-exception", ":comment:comment-api-readmodel", ":comment:comment-application", ":comment:comment-rdb-adapter", ":comment:comment-webmvc-adapter", ) project(":comment").projectDir = comment("comment") project(":comment:comment-api").projectDir = comment("api") project(":comment:comment-api-domain").projectDir = comment("domain") project(":comment:comment-api-exception").projectDir = comment("exception") project(":comment:comment-api-readmodel").projectDir = comment("readmodel") project(":comment:comment-application").projectDir = comment("application") project(":comment:comment-rdb-adapter").projectDir = comment("rdb") project(":comment:comment-webmvc-adapter").projectDir = comment("web-mvc")

silberbullet · 2025-05-06T07:47:40Z

services/comment/driven/rdb/src/main/java/nettee/reply/entity/ReplyEntity.java

+@Getter
+@DynamicUpdate
+@NoArgsConstructor(access = AccessLevel.PROTECTED)
+@Entity(name = "comment")
+public class ReplyEntity extends LongBaseTimeEntity {
+
+    @Id
+    private Long id;
+
+    private String content;
+
+    @Convert
+    private ReplyEntityStatus status;
+}


엔티티 관련한 문의사항이 있습니다!

접근제한자 private

Entity 필드의 접근 제한자는 멀티 모듈 환경에서 public으로 지정하기로 하였습니다.

모듈이란 스코프 내에서 코딩이 이루어지기 때문에 private는 불필요 했습니다.

테스트 코드를 짤 때 더 유연해집니다.

@convert에 컨버터를 위한 클래스 지칭

Convert는 따로 해당 필드를 위한 컨버터 클래스를 지칭해야 하는 것으로 알고 있습니다. 혹시 이 작업은 누락일까요?

board 예시

@Getter @DynamicUpdate @NoArgsConstructor(access = AccessLevel.PROTECTED) @Entity(name = "board") public class BoardEntity extends LongBaseTimeEntity { public String title; public String content; @Convert(converter = BoardEntityStatusConverter.class) public BoardEntityStatus status; @Builder public BoardEntity(String title, String content, BoardEntityStatus status) { this.title = title; this.content = content; this.status = status; } }

builder 패턴을 적용하지 않은 이유가 있을까요?

services/comment/driven/rdb/build.gradle.kts

…e.kts

seonghooni added 7 commits May 3, 2025 23:05

feat(comment): add comment-service build gradle file

8653bd8

fix(board): add flyway to board.database-local.yml

fe8311f

feat(comment/reply): create domain, exception, read-model to api module

11a0274

feat(comment/reply): create port to application module

6a8053d

feat(comment/reply): create entity to driven/entity module

95edb7d

build(comment/reply): create yml, postgresql script to entity module

e41ab5b

build(comment/reply): build comment module configurations (settings.g…

223fd5d

…radle.kts, yml, build.gradle.kts)

seonghooni requested review from merge-simpson, silberbullet and wch-os May 3, 2025 14:37

merge-simpson requested review from wowddok99, jilpoom, sweetykr7, Ropung and taewookimm May 3, 2025 14:53

merge-simpson assigned seonghooni May 5, 2025

merge-simpson added review: required Reviews are required type: feature 새로운 기능 또는 기능적 개선 A new feature or enhancement in: comment Issues in the comment module labels May 5, 2025

merge-simpson reviewed May 5, 2025

View reviewed changes

silberbullet reviewed May 6, 2025

View reviewed changes

services/comment/driven/rdb/build.gradle.kts Outdated Show resolved Hide resolved

seonghooni added 7 commits May 11, 2025 21:24

fix: merge conflict resolved in build.gradle.kts

7efcd78

fix(comment/reply): rename postgresql files

22bb9f3

fix(comment/reply): fix typo/syntax in entity

734e71c

build(comment/reply): modify build.gradle.kts, settings.gradle.kts

caf146d

feat(comment/reply): add EntityStatusConverter

de2beaa

fix(comment/reply): modify comment/driven/rdb/build.gradle.kts

2a2af19

fix(comment/reply): resolve conflict monolith/main-runner/build.gradl…

746daea

…e.kts

merge-simpson changed the title ~~Comment - comment 모듈 추가 및 application, api 작성~~ Comment: comment 모듈 추가 및 application, api 작성 May 13, 2025

merge-simpson requested review from merge-simpson and silberbullet May 17, 2025 05:59

merge-simpson added review: ing Reviews are in progress and taking time and removed review: required Reviews are required labels May 17, 2025

seonghooni added 11 commits May 18, 2025 18:55

refactor(comment/reply): add builder method to entity

970cfc4

refactor(comment/reply): add fk to domain

8bb4c97

feat(comment/reply): add RDB adapter(command,query)

c8814aa

refactor(comment/reply): remove getter annotation from entity

c4c602f

refactor(comment/reply): modify function, parameter of port and adapter

5b77667

feat(comment/reply): add QueryService, CommandService, UseCase

0488fb9

refactor(comment/reply): modify readModels, port, adapter

f0d73b2

feat(comment/reply): add command service, query service

7097736

feat(comment/reply): add command api, query api, dto to web-mvc module

a990533

refactor(comment/reply): modify base-package according to #86

d0062f7

refactor(comment/reply): add boardId field to CommentDetail

b007832

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comment: comment 모듈 추가 및 application, api 작성 #68

Comment: comment 모듈 추가 및 application, api 작성 #68

seonghooni commented May 3, 2025 •

edited

Loading

merge-simpson May 5, 2025 •

edited

Loading

silberbullet May 6, 2025

silberbullet May 6, 2025

Comment: comment 모듈 추가 및 application, api 작성 #68

Are you sure you want to change the base?

Comment: comment 모듈 추가 및 application, api 작성 #68

Conversation

seonghooni commented May 3, 2025 • edited Loading

Pull Request

Issues

Description

How Has This Been Tested?

Additional Notes

merge-simpson May 5, 2025 • edited Loading

Choose a reason for hiding this comment

❗️ "web-mvc" 폴더가 존재하지 않습니다.

silberbullet May 6, 2025

Choose a reason for hiding this comment

silberbullet May 6, 2025

Choose a reason for hiding this comment

엔티티 관련한 문의사항이 있습니다!

seonghooni commented May 3, 2025 •

edited

Loading

merge-simpson May 5, 2025 •

edited

Loading

❗️ `"web-mvc"` 폴더가 존재하지 않습니다.