Skip to content

Board: 각 모듈의 Base Package 구분 #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 105 commits into
base: main
Choose a base branch
from
Open

Board: 각 모듈의 Base Package 구분 #94

wants to merge 105 commits into from

Conversation

merge-simpson
Copy link
Member

Issues

Description

  • Board 관련 모듈들에 고유한 base package를 할당합니다.
  • BoardErrorCode를 이제 통합해서 관리합니다.

Review Points

  • 모듈별 베이스 패키지 이름이 알맞게 입력되었는지 검토해 주세요.
  • 혹시 더 개선할 네이밍이 있다면 말씀해 주세요.

How Has This Been Tested?

  • 실행 여부(컴파일·빌드·부트타임 통과)를 육안으로 확인했습니다.
  • 별도 테스트 코드가 필요하지 않은 작업이었습니다. (Board 관련 모듈들에 테스트 코드가 아직 없기 때문입니다.)

JeongJeongYong and others added 30 commits April 29, 2025 22:38
feat(common): add EnumUtil to common module
429ee6c
@silberbullet
build(rest-client): add rest-client module
1f79137
@silberbullet
build(rest-client): add spring web library
3795b97
@silberbullet
build(core): add client-api and rest-client module
fe4778c
@silberbullet
feat(client): add client-api module
3f2322a
@silberbullet
feat(client): add ClientProperties record class
39b1b2a
@silberbullet
feat(rest-client): add nettee-rest-client module with spring web 6.2.6
ac2e8e3
@silberbullet
build(rest-client): add client api module in rest-client module
686aee1
@silberbullet
build(rest-client): add client api module in rest-client module
e563cbc
@silberbullet
fix(core): delete file
003bdd0
@silberbullet
build(client-api): fix api to use configuration annotation other module
3467dba
@silberbullet
feat(rest-client): add RestClient config to build singleton
85b5432
@silberbullet
fix(rest-client): add static set nettee client when add rest client b…
2360472 
…ean in spring context
@silberbullet
feat(rest-client): add request record in HttpRequests.java class
645d45b
@silberbullet
feat(client-api): add request record
a405be7
@silberbullet
fix(rest-client): delete request record
6442291
@silberbullet
feat(rest-client): add custom rest client NetteeClient.java
947b31a
@silberbullet
chore(rest-client): add comment
7f9c446
Merge branch 'main' into feature/enum-util
d166de2
fix(common): modularize EnumUtil in common module
bc1ef22
feat(board): add uniqueness check for BoardStatus using EnumUtil
e90b1af
@silberbullet
build(rest-client): add test library
f3111be
@silberbullet
feat(rest-client): add get list function
e8ba861
@silberbullet
feat(rest-client): add test code with sample student api
254d9a3
@merge-simpson
feat(common): add default error code and holder in CustomException
dd26cd4
@merge-simpson
feat(common): add default-error-code-based constructors in `CustomExc…
30d9fff 
…eption`
@merge-simpson
chore(common): suppress lombok getter intention in CustomException
608cc83
@silberbullet
fix(rest-client): add package name
be8afe1
@silberbullet
chore(rest-client): merge main branch
2c57b6c
@silberbullet
feat(board): add board nettee client module
0e6735f
silberbullet and others added 18 commits May 17, 2025 13:49
@silberbullet @merge-simpson
fix(rest-client): change type to Supplier to functional exception
2cbd8e5
@silberbullet @merge-simpson
fix(rest-client): change throw exception
bfd6544
@silberbullet @merge-simpson
feat(board): add nettee client port for example
5b730ca
@silberbullet @merge-simpson
build(board): add board nettee client build.gradle.kts
fc9d292
@silberbullet @merge-simpson
feat(board): add board nettee client for example
0329226
@silberbullet @merge-simpson
feat(client-api): add logging library
c698a1a
@silberbullet @merge-simpson
refactor(client-api): delete custom exception and add body adn unwrapKey
a307fb1
@silberbullet @merge-simpson
refactor(rest-client): change singleton pattern for spring
f1d3253
@silberbullet @merge-simpson
refactor(rest-client): add unwraphandler while body spec handle
d82b1df
@silberbullet @merge-simpson
refactor(rest-client): fix singleton and add bean
df864e5
@silberbullet @merge-simpson
build(rest-client): add object mapper library
928841d
@merge-simpson
Merge remote-tracking branch 'origin/feature/core-rest-client' into f…
f6af1fd 
…eature/core-rest-client

# Conflicts:
#	monolith/main-runner/build.gradle.kts
#	services/board/board.settings.gradle.kts
@merge-simpson
build(board): fix to use correct directory finder name "boardDirectory"
d72b0a1
@merge-simpson
build(board): add property for board rest client
eb671ae
@merge-simpson
build(board): fix typo of property for board rest client
cc6572f
@merge-simpson
Merge pull request #71 from nettee-space/feature/core-rest-client
b48bb29 
Core > Rest Client Core 모듈 구현
@merge-simpson
Merge pull request #73 from nettee-space/feature/default-error-code
a892d72 
Common: Default Error Code 추가
@merge-simpson
Merge pull request #69 from nettee-space/feature/enum-util
5614a7c 
Common: EnumUtil 추가 및 `BoardStatus`에 적용
@merge-simpson merge-simpson added the review: ing Reviews are in progress and taking time label May 17, 2025
@merge-simpson
refactor(board-domain): use base-package as nettee.board.domain
fa56330
@merge-simpson
refactor(board-exception): use base-package as nettee.board.exception
cc71a10
@merge-simpson
refactor(board-application): use base-package as `nettee.board.applic…
e23aa98 
…ation`
@merge-simpson
refactor(board-rdb-adapter): use base-package as `nettee.board.driven…
1b035f1 
….rdb`
@merge-simpson
refactor(board-webmvc): use base-package as nettee.board.driving.web
f4ca5a2
@merge-simpson
refactor(board): remove BoardQueryErrorCode.java and `BoardQueryExc…
4099c5a 
…eption.java`
@merge-simpson
refactor(board): rename BoardCommandErrorCode to BoardErrorCode
007127e
@merge-simpson
Merge remote-tracking branch 'origin/feature/board-base-package' into…
272980e 
… feature/board-base-package

# Conflicts:
#	services/board/api/domain/src/main/java/nettee/board/domain/type/BoardStatus.java
@merge-simpson
fix(board-domain): recover BoardStatus
2a9af92
@merge-simpson
build(board): fix unresolved boardRestClient property that wasn't imp…
f468232 
…orted
@merge-simpson
Copy link
Member Author

merge-simpson commented May 17, 2025 •
edited
Loading

💡 Diff 확인하기

▶ 이동

📣 일부 conflict 해결을 위해 main 브랜치에 대해 rebase 했습니다.
받아 온 commit이 추가되면서 file changed 탭에 노출되는 파일 수가 증가했습니다.

PR과 별개로 단순히 main 브랜치와 차이를 보고 싶다면 하기 링크를 이용해 주세요.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sweetykr7 sweetykr7 sweetykr7 approved these changes

@wowddok99 wowddok99 Awaiting requested review from wowddok99

@jilpoom jilpoom Awaiting requested review from jilpoom

@silberbullet silberbullet Awaiting requested review from silberbullet

@Ropung Ropung Awaiting requested review from Ropung

@wch-os wch-os Awaiting requested review from wch-os

@seonghooni seonghooni Awaiting requested review from seonghooni

@taewookimm taewookimm Awaiting requested review from taewookimm

@shin-jingyu shin-jingyu Awaiting requested review from shin-jingyu

At least 2 approving reviews are required to merge this pull request.

Assignees

@merge-simpson merge-simpson

Labels
in: board Issues in the board module review: ing Reviews are in progress and taking time type: refactor A code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

☀️ Board: BoardErrorCode로 통합 [SUB-ISSUE] Board: 모듈별 베이스 패키지 구분
3 participants
@merge-simpson @sweetykr7 @silberbullet