omfdump: fixes and enhancements #84
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes decoding of FIXUP records - memory mapped IO converted to ordinary file IO for compatibility - ignores garbage after MODEND (produced by Digital Research RASM86) - adds / enhances decoding of several record types Signed-off-by: Bernd Boeckmann <bernd-github@boeckmann.io>
Member
|
I incorporated a bunch of your improvements for 3.00, but I'm not 100% I got them all due to codebase divergence. If there are still improvements you would like to make, please rebase them on the current master. Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reverse engineering an old Digital Research tool I noticed that the OMFDUMP utility from the NASM repo failed to correctly parse some OMF FIXUP records. I was also not able to compile it for DOS because of the memory mapped io.
So I made several changes to it:
I was able to build this with clang under Mac and Watcom C under DOS.