Skip to content

Conversation

@justin-tay
Copy link
Collaborator

Closes #1192

This fixes the underlying discrepancies in the code ranges for the character classes \d, \D, \w, \W, \s, \S in ECMA-262 vs the mappings to the unicode general categories. As such this also fixes the case where these character classes are used in a character set.

In the process of fixing this it was also noted that \p{digit} is mapping to \d where it should be to \p{Nd} so this was fixed as well.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 56.45161% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.10%. Comparing base (48ca3c2) to head (d50b582).
⚠️ Report is 97 commits behind head on master.

Files with missing lines Patch % Lines
.../networknt/schema/regex/JoniRegularExpression.java 56.45% 22 Missing and 5 partials ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1193      +/-   ##
============================================
- Coverage     78.90%   78.10%   -0.80%     
- Complexity     1965     2082     +117     
============================================
  Files           172      201      +29     
  Lines          6352     6930     +578     
  Branches       1255     1267      +12     
============================================
+ Hits           5012     5413     +401     
- Misses          867     1041     +174     
- Partials        473      476       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stevehu stevehu merged commit 2d9c327 into networknt:master Sep 13, 2025
4 checks passed
@justin-tay justin-tay deleted the gh1192 branch September 14, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JoniRegularExpression does not work with character class escapes (\s, \w, etc) within character classes ([])

3 participants