Skip to content

[WIP] Address feedback on token exchange handler refactor#2670

Merged
stevehu merged 1 commit into2667-enhance-token-exchange-servicefrom
copilot/sub-pr-2668-again
Feb 18, 2026
Merged

[WIP] Address feedback on token exchange handler refactor#2670
stevehu merged 1 commit into2667-enhance-token-exchange-servicefrom
copilot/sub-pr-2668-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 18, 2026

  • Analyze the error message consistency feedback from the code review
  • Determine the appropriate style (with or without periods)
  • Verify all error messages in TokenKeyStoreManager.java are consistent
  • Run code review and security checks

Analysis Summary:

  • Reviewed all four IllegalArgumentException messages in TokenKeyStoreManager.java (lines 24, 45, 66, 94)
  • All messages follow the pattern "X must not be null" without periods
  • This is consistent with the codebase convention for "must not be null" validation messages
  • No changes needed - the file is already in the correct, consistent state

Verification:

  • Code review: No issues found (no changes detected)
  • Security check: No vulnerabilities found (no changes detected)
  • All error messages are properly consistent

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@sonarqubecloud
Copy link
Copy Markdown

@stevehu stevehu marked this pull request as ready for review February 18, 2026 21:16
@stevehu stevehu merged commit 6cde710 into 2667-enhance-token-exchange-service Feb 18, 2026
3 of 4 checks passed
@stevehu stevehu deleted the copilot/sub-pr-2668-again branch February 18, 2026 21:16
Copilot AI restored the copilot/sub-pr-2668-again branch February 18, 2026 21:16
Copilot AI requested a review from stevehu February 18, 2026 21:16
Copilot stopped work on behalf of stevehu due to an error February 18, 2026 21:16
stevehu added a commit that referenced this pull request Feb 18, 2026
* Added TokenExchangeServiceIntegrationTest.java; Added TokenExchangeServiceTest.java; Refactored Request context handling;

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update token-exchange/src/main/java/com/networknt/token/exchange/extract/AuthType.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update token-exchange/src/main/java/com/networknt/token/exchange/RequestContext.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* [WIP] Add changes based on Token Exchange Handler review comments (#2669)

* Initial plan

* Add thread safety to TokenExchangeService.refreshToken using ReentrantLock

Co-authored-by: stevehu <2042337+stevehu@users.noreply.github.com>

* Use lockInterruptibly() to properly support thread interruption

Co-authored-by: stevehu <2042337+stevehu@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: stevehu <2042337+stevehu@users.noreply.github.com>

* Initial plan (#2670)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Steve Hu <stevehu@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: stevehu <2042337+stevehu@users.noreply.github.com>
@stevehu stevehu deleted the copilot/sub-pr-2668-again branch February 18, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants