Skip to content

Commit 5dba5c8

Browse files
authored
fix support for wandb run_name for rl trainers (axolotl-ai-cloud#2566) [skip ci]
* fix support for wandb run_name for rl trainers * prefer to use wandb random names for run_name
1 parent e3c9d54 commit 5dba5c8

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

src/axolotl/core/trainer_builder.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1048,6 +1048,9 @@ def build_training_arguments(self, total_num_steps):
10481048
if self.cfg.rpo_alpha is not None:
10491049
training_args_kwargs["rpo_alpha"] = self.cfg.rpo_alpha
10501050

1051+
if self.cfg.use_wandb:
1052+
training_args_kwargs["run_name"] = self.cfg.wandb_name
1053+
10511054
training_args_cls = None
10521055
blocklist_args_kwargs = []
10531056
if self.cfg.rl == "simpo":
@@ -1118,6 +1121,12 @@ def build_training_arguments(self, total_num_steps):
11181121
**training_args_kwargs,
11191122
)
11201123

1124+
# unset run_name so wandb sets up experiment names
1125+
if self.cfg.use_wandb and training_args.run_name == training_args.output_dir:
1126+
training_args.run_name = ( # pylint: disable=attribute-defined-outside-init
1127+
None
1128+
)
1129+
11211130
return training_args
11221131

11231132
def build(self, total_num_steps):

0 commit comments

Comments
 (0)