-
-
Notifications
You must be signed in to change notification settings - Fork 1
Move default directives (Deploy and Test) to end of directive list instead of beginning #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: stebo85 <4021595+stebo85@users.noreply.github.com>
Co-authored-by: stebo85 <4021595+stebo85@users.noreply.github.com>
Resolve conflicts |
@copilot resolve conflicts |
- Removed bun.lock file (deleted in main) - Preserved default directives implementation - Integrated with latest main branch changes including tests and new features
Conflicts resolved successfully in commit bd7fe49. The main conflict was with the
Conflicts resolved in commit bd7fe49. The merge was successful and the default directives functionality is working perfectly. Testing confirms that new containers now show "2 directives" (Deploy and Test) instead of starting empty, which addresses the original issue #42. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but default directives should be at the end instead of the start.
@copilot make my requested change |
Changed both template functions to use spread operator to append default directives to the end of existing directives array instead of prepending them at the beginning. This addresses user feedback that default directives should be positioned at the end. - Modified startFromScratch.ts to append defaults at end - Modified pythonPackage.ts to append defaults at end - Verified both "Start from Scratch" and "Python Package" templates now show default Deploy and Test directives at the end - Start from Scratch: shows Deploy (#1) and Test (#2) at end - Python Package: shows Deploy (#4) and Test (#5) after Miniconda and package-specific directives Co-authored-by: Vbitz <368827+Vbitz@users.noreply.github.com>
Default directives have been moved to the end as requested. Both templates now append default Deploy and Test directives at the end instead of the beginning. ✅ Start from Scratch: Deploy (#1) and Test (#2) at end Implemented in commit ead42e3. The change was minimal - just swapped the spread operator order in both template functions to ensure defaults are appended rather than prepended. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
When creating new containers through the guided tour, default directives (Deploy and Test) were being added at the beginning of the directive list, which created an unexpected order for users who expected template-specific directives to come first.
This PR moves the default directives to the end of the directive list for a more logical ordering:
Before
After
Changes Made
Updated both container template functions to position default directives at the end:
This change ensures that template-specific directives (like Miniconda setup for Python packages) appear first, followed by the standard Deploy and Test directives that apply to all containers.
The implementation maintains backward compatibility while providing a more intuitive directive ordering that matches user expectations.
Fixes #42.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.