Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Aug 11, 2025

When creating new containers through the guided tour, default directives (Deploy and Test) were being added at the beginning of the directive list, which created an unexpected order for users who expected template-specific directives to come first.

This PR moves the default directives to the end of the directive list for a more logical ordering:

Before

After

Changes Made

Updated both container template functions to position default directives at the end:

// Before
directives: [...createDefaultDirectives(), ...directives]

// After  
directives: [...directives, ...createDefaultDirectives()]

This change ensures that template-specific directives (like Miniconda setup for Python packages) appear first, followed by the standard Deploy and Test directives that apply to all containers.

The implementation maintains backward compatibility while providing a more intuitive directive ordering that matches user expectations.

Default Directives Implementation

Fixes #42.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Copilot AI and others added 2 commits August 11, 2025 07:23
Co-authored-by: stebo85 <4021595+stebo85@users.noreply.github.com>
Co-authored-by: stebo85 <4021595+stebo85@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] default directives Add default directives to new containers including Deploy and Test Aug 11, 2025
@Copilot Copilot AI requested a review from stebo85 August 11, 2025 07:30
Copilot finished work on behalf of stebo85 August 11, 2025 07:30
@stebo85 stebo85 marked this pull request as ready for review August 12, 2025 20:32
@stebo85
Copy link
Contributor

stebo85 commented Aug 12, 2025

Resolve conflicts

@Vbitz
Copy link
Collaborator

Vbitz commented Aug 13, 2025

@copilot resolve conflicts

- Removed bun.lock file (deleted in main)
- Preserved default directives implementation
- Integrated with latest main branch changes including tests and new features
Copy link
Contributor Author

Copilot AI commented Aug 13, 2025

Resolve conflicts

Conflicts resolved successfully in commit bd7fe49. The main conflict was with the bun.lock file which was deleted in main but modified in our branch. The merge preserves the default directives functionality while integrating with all the latest main branch improvements including test suites and new features.

@copilot resolve conflicts

Conflicts resolved in commit bd7fe49. The merge was successful and the default directives functionality is working perfectly. Testing confirms that new containers now show "2 directives" (Deploy and Test) instead of starting empty, which addresses the original issue #42.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • fonts.googleapis.com
    • Triggering command: next-server (v15.3.3) (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@Copilot Copilot AI requested a review from Vbitz August 13, 2025 01:17
Copilot finished work on behalf of Vbitz August 13, 2025 01:17
Copy link
Collaborator

@Vbitz Vbitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but default directives should be at the end instead of the start.

@Vbitz
Copy link
Collaborator

Vbitz commented Aug 13, 2025

@copilot make my requested change

Changed both template functions to use spread operator to append
default directives to the end of existing directives array instead
of prepending them at the beginning. This addresses user feedback
that default directives should be positioned at the end.

- Modified startFromScratch.ts to append defaults at end
- Modified pythonPackage.ts to append defaults at end
- Verified both "Start from Scratch" and "Python Package" templates
  now show default Deploy and Test directives at the end
- Start from Scratch: shows Deploy (#1) and Test (#2) at end
- Python Package: shows Deploy (#4) and Test (#5) after Miniconda
  and package-specific directives

Co-authored-by: Vbitz <368827+Vbitz@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Aug 13, 2025

@copilot make my requested change

Default directives have been moved to the end as requested. Both templates now append default Deploy and Test directives at the end instead of the beginning.

Start from Scratch: Deploy (#1) and Test (#2) at end
Python Package: Deploy (#4) and Test (#5) at end (after package-specific directives)

Implemented in commit ead42e3. The change was minimal - just swapped the spread operator order in both template functions to ensure defaults are appended rather than prepended.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • fonts.googleapis.com
    • Triggering command: next-server (v15.3.3) (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@Vbitz Vbitz merged commit 2bee12d into main Aug 13, 2025
@Vbitz Vbitz deleted the copilot/fix-42 branch August 13, 2025 01:50
@Copilot Copilot AI changed the title Add default directives to new containers including Deploy and Test Move default directives (Deploy and Test) to end of directive list instead of beginning Aug 13, 2025
@Copilot Copilot AI requested a review from Vbitz August 13, 2025 01:50
Copilot finished work on behalf of Vbitz August 13, 2025 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default directives
3 participants