-
Notifications
You must be signed in to change notification settings - Fork 22
Refactor documentation #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @JoeZiminski, I have added a few comments based on my observations regarding the user experience. Please have a look, and feel free to ignore anything that may not be necessary. Thank you! |
Hey @JoeZiminski I think this PR also contains the contents of #492. |
15c0889
to
7bd8e28
Compare
Thanks Both! Ah yes I did branch off as you mention @cs7-shrey, once #492 is merged I will rebase this back on main and drop those commits! |
1100b83
to
c829cf6
Compare
|
||
**datashuttle** requires | ||
``datashuttle`` requires |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think here we should suggest a way for users to get Python if needed, maybe like we do in BrainGlobe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To simplify things for the user (and us when when supporting), should we only recommend a conda-based installation? Users can of course use their own installation if they know what they're doing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean from the new link (i.e. recommend using conda to install python (see this guide for how...)
or to remove the Pip
tab from the installation instructions? I agree for the former, for the later I think it can be useful to have the Pip
tab there just in case there are new users who have had trouble with conda installations (generally on Windows).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, yes I meant a conda installation of Python
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great will make that change
be5ba7d
to
4373bd6
Compare
Cheers @adamltyson! Let me know what you think of the suggested changes |
Hey @adamltyson thanks for the review I think the docs are much clearer for new users now, let me know if any further changes are needed |
Yep, looks good. I think this PR is good to merge, we can look to tweak bits here and there as we go rather than trying to make everything perfect in this PR. |
This PR reworks the documentation to be more accessible for first-time users. The main changes are:
For review, don't think reviewing the diff would be that useful as there are a lot of formatting changes. However it would be great to get feedback on how accessible the docs layout etc. seem for new users. The actual content of the documentation has not changed (except for the 'Set up a project' page).