Skip to content

Refactor documentation #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Jun 5, 2025
Merged

Refactor documentation #499

merged 36 commits into from
Jun 5, 2025

Conversation

JoeZiminski
Copy link
Member

@JoeZiminski JoeZiminski commented Mar 21, 2025

This PR reworks the documentation to be more accessible for first-time users. The main changes are:

  • Better split the documentation into 'Getting Started' and more detailed 'User Guides' section. Now Getting Started contains all guides to quickly get set up, and does not require setting up transfer-related configs to get started (e.g. if only validating or creating folders)
  • Add some detail as to the purpose of datashuttle to the front page
  • Add two example scripts for how datashuttle is used in the real world
  • In general tidy up and update the documentation

For review, don't think reviewing the diff would be that useful as there are a lot of formatting changes. However it would be great to get feedback on how accessible the docs layout etc. seem for new users. The actual content of the documentation has not changed (except for the 'Set up a project' page).

@sumana-2705
Copy link
Contributor

Hello @JoeZiminski, I have added a few comments based on my observations regarding the user experience. Please have a look, and feel free to ignore anything that may not be necessary. Thank you!

@cs7-shrey
Copy link
Collaborator

Hey @JoeZiminski I think this PR also contains the contents of #492.
I'm not sure if that was intended.
I think you did a git checkout on add_validation_to_tui branch

@JoeZiminski JoeZiminski force-pushed the refactor_documentation branch from 15c0889 to 7bd8e28 Compare March 22, 2025 19:56
@JoeZiminski
Copy link
Member Author

Thanks Both! Ah yes I did branch off as you mention @cs7-shrey, once #492 is merged I will rebase this back on main and drop those commits!

@JoeZiminski JoeZiminski mentioned this pull request Mar 23, 2025
@JoeZiminski JoeZiminski mentioned this pull request May 21, 2025
7 tasks
@JoeZiminski JoeZiminski marked this pull request as ready for review May 22, 2025 15:33
@JoeZiminski JoeZiminski force-pushed the refactor_documentation branch from 1100b83 to c829cf6 Compare May 22, 2025 16:15
@JoeZiminski JoeZiminski requested a review from a team May 22, 2025 16:15

**datashuttle** requires
``datashuttle`` requires
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here we should suggest a way for users to get Python if needed, maybe like we do in BrainGlobe.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a link to Real Python's installation guide, there is a guide to conda installation in the 'Conda' box if this seems enough:

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To simplify things for the user (and us when when supporting), should we only recommend a conda-based installation? Users can of course use their own installation if they know what they're doing.

Copy link
Member Author

@JoeZiminski JoeZiminski Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean from the new link (i.e. recommend using conda to install python (see this guide for how...) or to remove the Pip tab from the installation instructions? I agree for the former, for the later I think it can be useful to have the Pip tab there just in case there are new users who have had trouble with conda installations (generally on Windows).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, yes I meant a conda installation of Python

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great will make that change

@JoeZiminski JoeZiminski force-pushed the refactor_documentation branch from be5ba7d to 4373bd6 Compare May 23, 2025 20:07
@JoeZiminski
Copy link
Member Author

Cheers @adamltyson! Let me know what you think of the suggested changes

@JoeZiminski JoeZiminski requested a review from adamltyson June 3, 2025 18:38
@JoeZiminski
Copy link
Member Author

Hey @adamltyson thanks for the review I think the docs are much clearer for new users now, let me know if any further changes are needed

@adamltyson
Copy link
Member

Yep, looks good. I think this PR is good to merge, we can look to tweak bits here and there as we go rather than trying to make everything perfect in this PR.

@JoeZiminski JoeZiminski merged commit 8f8aa90 into main Jun 5, 2025
16 checks passed
@JoeZiminski JoeZiminski deleted the refactor_documentation branch June 5, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write blog explaining how to integrate datashuttle into existing pipelines.
4 participants