-
Notifications
You must be signed in to change notification settings - Fork 22
Add Google Drive and AWS S3 as a Remote Storage option #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cs7-shrey
wants to merge
65
commits into
neuroinformatics-unit:main
Choose a base branch
from
cs7-shrey:add_gdrive_aws_remote
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
83ac1f4
google drive setup via python api first draft
e37861e
enable google drive config setup via tui
01503f7
minor compatibility and ui changes
7380bac
protectedclient secret input box
965e016
google drive connection setup via TUI
6698cb0
add aws as remote storage via python api first draft
60b77aa
add: logging and connection check for aws s3
d9755da
update: type checking for aws regions
f3947a7
add: save aws configs via TUI
b328af9
add: setup aws connection via TUI
d2a4d83
feat: setup google drive on machines with no browser
d9ae864
fix: minor bug
965bb17
fix: logical error
377cea7
add: logging for google drive connections
409d448
refactor: move google drive client secret to be entered at runtime wh…
0b33b86
refactor: aws_regions.py; provide aws secret access key at runtime
0733f51
add: docstrings to gdrive.py
023ada3
add: root_folder_id config to google drive; some refactor
e869986
refactor: radiobuttons switch in configs.py
9edbc8f
edit: minor changes to SetupAwsScreen for setting up aws connection
150f2ea
refactor: SetupGdriveScreen and handle errors
70659cd
add: some tooltips for google drive configs
985e921
fix: vanishing central path, radio button order, minor refactor
d7f13d4
fix: minor bug
f7807d1
refactor: single button for setup connection
be8f6b1
add: backwards compatibility to configs while load from config file
0b7483b
edit: raise error on bucket not present
2579827
rename: aws region config key
0a1ca87
rename: connection method from aws_s3 to aws
8bb7c28
add: utility function to remove duplicate code
8beaa42
add: docstrings to setup gdrive dialog
e53984b
update: config dict inplace change for backward compatibility, use ex…
772c3c1
add: docstrings to setup connection functions; remove: aws region class
91f2454
add: docstrings to setup widgets function; use backwards compatibility
ee88875
add: docstrings to rclone function, change arugment order
c0a7eca
minor changes
eb3f098
refactor: centralize the get secret function
ad8e9b1
extend centralized function for sensitive information input to ssh co…
d46fd01
convert stage from float to int
730c2c5
add: function for getting aws bucket name
3c0e9cd
refactor: connection methods list
8e175b5
move: widgets not match saved configs
93acc67
Merge remote-tracking branch 'upstream/main' into add_gdrive_aws_remote
JoeZiminski 2c4c941
Fix linting.
JoeZiminski 3ae5ea6
fix: overly long container in configs tab
bc073e6
add: first version of service account file setup method
5b6282f
remove: utility functions and docstrings in python api for config tok…
da421c8
fix: css
c1cf1ab
update: setup gdrive screen to use service account file and refactor …
7ccc6de
rename: existing functions from config token -> service account
6c91bb2
edit: docstrings in accordance with new connection setup
31bad6d
update: function for checking successful rclone connection
6f7a53e
edit: setup aws screen css
42d2ef0
Fix assert in CreateFolders.
JoeZiminski d0f948c
Allow no central_path for aws or gdrive and refactor configs_content.
JoeZiminski af60167
Fix tests.
JoeZiminski 887587a
Merge remote-tracking branch 'upstream/main' into add_gdrive_aws_remote
JoeZiminski 05e9fe8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 590872b
Fix linting.
JoeZiminski 24f93a8
Merge branch 'add_gdrive_aws_remote' of https://github.com/cs7-shrey/…
JoeZiminski 8bfa77d
Add tests for new base path behaviour.
JoeZiminski 9fb0601
add: call rclone with popen; refactor: google drive connection to use…
ac54a8f
fix: failing typehint on python 3.9
6276c0e
fix: another failing typehint
ed5cfd2
fix: failing monkeypatch
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
from typing import List, Literal, get_args | ||
|
||
# ----------------------------------------------------------------------------- | ||
# AWS regions | ||
# ----------------------------------------------------------------------------- | ||
|
||
AwsRegion = Literal[ | ||
"us-east-1", | ||
"us-east-2", | ||
"us-west-1", | ||
"us-west-2", | ||
"ca-central-1", | ||
"eu-west-1", | ||
"eu-west-2", | ||
"eu-west-3", | ||
"eu-north-1", | ||
"eu-south-1", | ||
"eu-central-1", | ||
"ap-southeast-1", | ||
"ap-southeast-2", | ||
"ap-northeast-1", | ||
"ap-northeast-2", | ||
"ap-northeast-3", | ||
"ap-south-1", | ||
"ap-east-1", | ||
"sa-east-1", | ||
"il-central-1", | ||
"me-south-1", | ||
"af-south-1", | ||
"cn-north-1", | ||
"cn-northwest-1", | ||
"us-gov-east-1", | ||
"us-gov-west-1", | ||
] | ||
|
||
|
||
def get_aws_regions_list() -> List[str]: | ||
"""Return AWS S3 bucket regions as a list.""" | ||
return list(get_args(AwsRegion)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.