Skip to content

Ensure Windows CI uses D: drive #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Udayscode
Copy link

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

This PR addresses Issue #499 ("Use D: drive for Windows CI") in the movement repository. The goal is to ensure that the Windows CI environment consistently uses the D: drive, which is the default in GitHub Actions and offers better I/O performance compared to C: . This consistency prevents potential drive-related failures and optimizes CI runtime.

What does this PR do?

Adds a new step "Ensure D: Drive on Windows" to .github/workflows/test_and_deploy.yml under the test job. The step:

  • Checks if the current directory is on the D: drive using %CD%.
  • If not, switches to D: and sets the working directory to %GITHUB_WORKSPACE% (the repository root).
    -Stops the job with an error if switching to D: fails, making it more reliable.
  • Shows the current directory in the logs so we can check it.

References

How has this PR been tested?

  • Checked YAML syntax locally in VS Code.
  • CI will run the test job on windows-latest. Logs in "Checks" tab will show:
    • "Already on D: drive" or "Now on: %GITHUB_WORKSPACE%".
    • Job passes if D: works, stops with an error if it doesn’t.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@Udayscode Udayscode marked this pull request as ready for review March 26, 2025 19:38
@adamltyson
Copy link
Member

See brainglobe/brainglobe-workflows#143, as this may not be necessary. Certainly worth looking into OS-specific caches (brainglobe/brainglobe-workflows#142) first if this isn't already implemented.

@niksirbi
Copy link
Member

niksirbi commented Apr 1, 2025

@Udayscode this PR now also contains changes related to #525. Have you perhaps pushed to the wrong branch?

Copy link

sonarqubecloud bot commented Apr 2, 2025

@Udayscode
Copy link
Author

@niksirbi Hey, I've updated the PR to only include changes up to commit 9e596be (Windows CI fixes for #499). The extra changes from #525 have been removed. Could you please take a look and let me know if it’s good now? Thanks!

@niksirbi
Copy link
Member

niksirbi commented Apr 3, 2025

@niksirbi Hey, I've updated the PR to only include changes up to commit 9e596be (Windows CI fixes for #499). The extra changes from #525 have been removed. Could you please take a look and let me know if it’s good now? Thanks!

Thanks @Udayscode.

I suggest you take a look at Adam's message above. Instead of using the D drive, we have found that using OS-specific caches is what makes the difference. I suggest you either:

@Udayscode Udayscode closed this Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants