Skip to content

PIC-safe assembly for librfxcodec #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Sep 15, 2017
Merged

PIC-safe assembly for librfxcodec #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
53393f4
Free the ebx register from use by the assembly code
mirabilos Jan 26, 2017
7e628bb
Convert i386 asm code to ELF PIC
mirabilos Jan 26, 2017
cd03880
Merge remote-tracking branch 'upstream/devel' into asm-elf-pie
mirabilos Mar 25, 2017
7f061cc
let common.asm end in the .text section
mirabilos Mar 25, 2017
0b4f260
define a macro to make the current architecture known to common.asm
mirabilos Mar 25, 2017
7b6e65a
move i386 ELF PIC stuff to common.asm
mirabilos Mar 25, 2017
4f940da
lsym() for amd64
mirabilos Mar 25, 2017
a96f21a
rename get_GOT to RETRIEVE_RODATA; don’t define it on amd64 (since we…
mirabilos Mar 25, 2017
d743ec0
new macro PREPARE_RODATA to denote the begin of (soon to be read-only…
mirabilos Mar 25, 2017
7cd86ad
move the i386 ELF PIC init code into PREPARE_RODATA
mirabilos Mar 25, 2017
3ce63c3
use label-relative, not GOT, access for local data in i386 ELF PIC
mirabilos Mar 25, 2017
ec38927
use i386 label-relative mechanism also for non-ELF formats
mirabilos Mar 25, 2017
b5352b5
move all (now read-only) data to the text section on all architectures
mirabilos Mar 25, 2017
ce09add
remove useless semicolons and undesirable 'align 16' at end of file
mirabilos Mar 25, 2017
fb9e996
add new END_OF_FILE macro; use it to place the small i386 PIC code late
mirabilos Mar 25, 2017
47be436
add EOF alignment for OSX linker; also simplify PREPARE_RODATA
mirabilos Mar 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/amd64/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
NAFLAGS += -DASM_ARCH_AMD64

AMD64_ASM = \
cpuid_amd64.asm \
rfxcodec_encode_dwt_shift_amd64_sse2.asm \
Expand Down
5 changes: 1 addition & 4 deletions src/amd64/cpuid_amd64.asm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
%include "common.asm"

section .text

;The first six integer or pointer arguments are passed in registers
;RDI, RSI, RDX, RCX, R8, and R9

Expand Down Expand Up @@ -32,5 +30,4 @@ PROC cpuid_amd64
; restore registers
pop rbx
ret
align 16

END_OF_FILE
Loading