fix: remove validator correctly; add migration to remote validator at correct height #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sotnikov-s
requested changes
Jun 4, 2025
NeverHappened
force-pushed
the
fix/remove-val
branch
from
fbdb46a to
4ccb837
Compare
sotnikov-s
reviewed
Jun 5, 2025
sotnikov-s
requested changes
Jun 6, 2025
Comment on lines
219
to
220
| #[test] | ||
| fn test_after_validator_removed_during_migration() { |
There was a problem hiding this comment.
I think it makes sense to
- bump contract's version in cargo.toml (
0.3.0probably?) - leave a note that this test is only for
0.2.1 -> 0.3.0migration
There was a problem hiding this comment.
Agree in general but:
- I think it must be 0.2.2, since it's just a bug fix, no interface/api/features changes
- Agree
sotnikov-s
approved these changes
Jun 6, 2025
|
Attach the test run, please |
pr0n00gler
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.