set nfd_migrate_site to false #831
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
14 tasks
arunshenoy99
approved these changes
Aug 7, 2025
Member
arunshenoy99
left a comment
arunshenoy99
left a comment
There was a problem hiding this comment.
LGTM, thanks! @geckod22 moving this to QA.
arunshenoy99
previously approved these changes
Sep 4, 2025
arunshenoy99
reviewed
Sep 4, 2025
Member
arunshenoy99
left a comment
arunshenoy99
left a comment
There was a problem hiding this comment.
@wpalani this has been tested and looks good to go. Can we get it merged and tagged into a release? It needs to go along with https://github.com/newfold-labs/wp-module-migration/pull/158, so we’ll need to coordinate on that. Thanks!
Member
|
@geckod22 looks like there's a merge conflict, can you resolve that? Also you don't have to commit build files as this is handled by the release workflow. |
Contributor
Author
|
@wpalani should be fine now. Let me know. |
arunshenoy99
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR aim to set the nfd_migration_site option to false once onboarding module run the first migration url step. This PR need to go with newfold-labs/wp-module-migration#158 that manage the dynamic sso onborading redirect for migration based on brand.
A customer start a Website Transfer from MFE, the option nfd_migration_site is set to true, then by sso url magic link the customer is redirected to the onboarding page for migration process. The migration module hooks on the sso success redirect and will dinamically set the url depending on the brand. Once onboarding start the migration process first step the option is set to false.
Type of Change
Production
Development
Visual
Checklist
Further comments