Step5 #6146
Open
Step5 #6146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mskangg
requested changes
Apr 3, 2025
Comment on lines
45
to
47
| public boolean equals(Car car) { | ||
| return equals(car.getPosition()); | ||
| } |
There was a problem hiding this comment.
오버라이딩하고 해시코드와 같이 선언하는게 좋을것 같아요!
왜그럴까요? 🤔
There was a problem hiding this comment.
상태가 같아도 메모리 주소가 다른 경우와 Hash Collection 을 사용할 경우 동등성 보장이 되지 않을수도 있기 때문이군요!
말씀해주신대로 수정해보겠습니다!
감사합니다.
Comment on lines
3
to
14
| public class RaceRecord { | ||
|
|
||
| private final Cars cars; | ||
|
|
||
| public RaceRecord(Cars cars) { | ||
| this.cars = cars; | ||
| } | ||
|
|
||
| public Cars getCars() { | ||
| return this.cars; | ||
| } | ||
| } |
There was a problem hiding this comment.
시도 횟수별 자동차들의 상태를 저장하는 객체로 생각했습니다!
sequence 필드를 추가해서 횟수별 자동차 상태를 가지는 객체로 리팩토링해보겠습니다.
|
|
||
| public class RaceRecords { | ||
|
|
||
| private final List<RaceRecord> values; |
There was a problem hiding this comment.
Suggested change
| private final List<RaceRecord> values; | |
| private final List<Cars> values; |
이렇게해도 차이점이 없을것 같아요!
There was a problem hiding this comment.
혹시 RaceRecord 객체에 sequence 필드를 추가했을 때, 기존 코드로 사용 가능한거 맞을까요??
sequence 필드 추가한 코드 커밋해보았습니다! 한 번 더 검토 부탁드립니다..!
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| import java.util.List; | |||
|
|
|||
| import racingcar.domain.*; | |||
There was a problem hiding this comment.
view 가 도메인을 의존하고 있네요 🤔
controller 를 통해 제어하는건 어떨까요?
Comment on lines
+32
to
+34
| - [x] CarManager 제거 | ||
| - [x] RaceRecord 추가 | ||
| - [x] TC 추가 및 리팩토링 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.