Skip to content

Remove modal header for smart picker dialogs #7036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: stable8
Choose a base branch
from
Open

Remove modal header for smart picker dialogs #7036

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/components/NcRichText/NcReferencePicker/NcReferencePickerModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,4 +186,13 @@ export default {
}
}
}
// Hide the empty modal header which prevents from accessing the close button
// Cannot use display:none because there's a `display: flex !important` in the
// Ncmodal component which would override it. This works because the
// `.modal-header` element has `position: absolute`.
// TODO: Add prop to NcModal to hide the header
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is a dialog then it should use NcDialog and not NcModal which also would fix this issue.

:deep(.modal-header) {
visibility: hidden;
}

</style>
Loading